Fix test 19 - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky t/19 spawn race on macOS
t/19-gnuplot-bin.t removed the fake gnuplot script with$fake.IO.unlink immediately after constructing the chart. Since Proc::Async starts the subprocess asynchronously, the unlink could win the race against the actual exec. On macOS (where $ *TMPDIR lives under /var/folders/...) this surfaced as:
Failed to spawn process .../fake-gnuplot-...: no such file or directory
and, because the rejected start promise was never awaited, it leaked out as an Unhandled exception in code scheduled on thread N that bled into other tests' output.
Fix: call $gnu.dispose before unlinking. dispose awaits the subprocess promise, so the binary is guaranteed to have been exec'd before the file is removed. Test-only change; the library itself is unaffected in normal usage with a real gnuplot.