Skip to content

refactor(admin): group player restrictions by concern #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
garrappachc wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

refactor(admin): group player restrictions by concern #805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions src/admin/player-restrictions/views/html/player-restrictions.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import type { Children } from '@kitajs/html'
import { configuration } from '../../../../configuration'
import { Switch } from '../../../../html/components/switch'
import { queue } from '../../../../queue-auto'
Expand All @@ -8,25 +9,40 @@ import { GameClassSkillInput } from '../../../../html/components/game-class-skil
export async function PlayerRestrictionsPage() {
return (
<Admin activePage="player-restrictions">
<form action="" method="post" id="playerRestrictionsForm">
<div class="admin-panel-set flex flex-col gap-4">
<form action="" method="post" id="playerRestrictionsForm" class="flex flex-col gap-4">
<Section title="Registration">
<RequireEtf2lAccount />
<MinimumTf2InGameHours />
</Section>

<Section title="Join queue">
<RequirePlayerVerification />
<PlayerSkillThreshold />
</Section>

<Section title="Skill">
<SkillStep />
<SkillSuggestions />
<DefaultPlayerSkill />
</Section>

<p>
<SaveButton />
</p>
</div>
<p>
<SaveButton />
</p>
</form>
</Admin>
)
}

function Section(props: { title: string; children: Children }) {
return (
<div>
<h2 class="text-abru-light-75 mb-2 text-xl font-bold">{props.title}</h2>
<div class="admin-panel-set flex flex-col gap-4">{props.children}</div>
</div>
)
}

async function RequireEtf2lAccount() {
const etf2lAccountRequired = await configuration.get('players.etf2l_account_required')
return (
Expand Down Expand Up @@ -135,7 +151,8 @@ async function PlayerSkillThreshold() {
/>
</div>
<p class="text-abru-light-75 text-sm">
Players will be able to join queue only on classes that meet the given criteria.
Players can join the queue on a given class only if their skill rating for that class is
at or above this value.
</p>
</dd>
</dl>
Expand Down Expand Up @@ -213,8 +230,8 @@ async function DefaultPlayerSkill() {
))}
</div>
<p class="text-abru-light-75 text-sm">
If a player starts a game without skill assigned for them, the game balance system will
use this fallback value.
Fallback skill rating for a player who has no skill set for a class yet — used both for
team balancing and for the skill-threshold check.
</p>
</dd>
</dl>
Expand Down
Loading