refactor(admin): group player restrictions by concern - #805
Draft
garrappachc wants to merge 1 commit into
Draft
Conversation
Separate registration and join-queue restrictions from skill config so the page's three distinct concerns are no longer mixed in one flat list, and clarify the skill-threshold and default-skill descriptions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Player restrictions admin page mixed three distinct concerns in one flat list of controls: registration gates (
players.*), join-queue gates (queue.*), and skill configuration (games.*) — the last of which aren't restrictions at all.This reorganizes the page into three labeled sections (Registration / Join queue / Skill) so the boundaries match the underlying config namespaces. Purely presentational: same single form, route, POST handler, schema, and config keys — no behavior change.
Also reworded two descriptions that were too vague to be actionable: