Skip to content

🍒 llvm: Use add_link_options for stack size flags #12896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Steelskin wants to merge 1 commit into
base: stable/21.x
Choose a base branch
from
+3 −2
Open

🍒 llvm: Use add_link_options for stack size flags #12896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/cmake/modules/HandleLLVMOptions.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,14 +547,15 @@ if( MSVC_IDE )
endif()

# set stack reserved size to ~10MB
set(_is_exe "$<STREQUAL:$<TARGET_PROPERTY:TYPE>,EXECUTABLE>")
if(MSVC)
# CMake previously automatically set this value for MSVC builds, but the
# behavior was changed in CMake 2.8.11 (Issue 12437) to use the MSVC default
# value (1 MB) which is not enough for us in tasks such as parsing recursive
# C++ templates in Clang.
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CMAKE_CXX_LINKER_WRAPPER_FLAG}/STACK:10000000")
add_link_options("$<${_is_exe}:LINKER:/STACK:10000000>")
elseif(MINGW OR CYGWIN)
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--stack,16777216")
add_link_options("$<${_is_exe}:LINKER:--stack,16777216>")

# Pass -mbig-obj to mingw gas to avoid COFF 2**16 section limit.
if (NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
Expand Down