🍒 llvm: Use add_link_options for stack size flags#12896
Open
Steelskin wants to merge 1 commit intoswiftlang:stable/21.xfrom
Open
🍒 llvm: Use add_link_options for stack size flags#12896Steelskin wants to merge 1 commit intoswiftlang:stable/21.xfrom
Steelskin wants to merge 1 commit intoswiftlang:stable/21.xfrom
Conversation
Previously, LLVM was directly editing `CMAKE_EXE_LINKER_FLAGS`. This is a user-facing CMake cache variable not meant to be modified by project code. This was causing issues for downstream consumers building non-C/C++ targets as part of the LLVM build. Modern CMake provides `add_link_options()`, a cleaner way to set linker flags that propagate to every target in a directory tree. Generator expressions and the `LINKER:` prefix syntax ensure that this is only applied to executable targets with the proper language and linker argument wrapping. Cherry-pick of llvm/llvm-project@4354248d10 (llvm#195034)
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, LLVM was directly editing
CMAKE_EXE_LINKER_FLAGS. This is a user-facing CMake cache variable not meant to be modified by project code. This was causing issues for downstream consumers building non-C/C++ targets as part of the LLVM build.Modern CMake provides
add_link_options(), a cleaner way to set linker flags that propagate to every target in a directory tree.Generator expressions and the
LINKER:prefix syntax ensure that this is only applied to executable targets with the proper language and linker argument wrapping.Cherry-pick of llvm/llvm-project@4354248d10 (llvm#195034)