-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): update dependency node to v24 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,6 +53,6 @@ jobs: | |
| fetch-depth: 0 | ||
| - uses: actions/setup-node@v7 | ||
| with: | ||
| node-version: 20 | ||
| node-version: 24 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Consider using a matrix strategy to test against multiple Node versions (e.g., 20, 22, and 24) or switch to Node 22 (Active LTS) to ensure stability while maintaining ecosystem compatibility. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Verify the intended Node.js version. Use Node 20 (Active LTS) or Node 22 (Current). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Use a valid Node.js version such as '20' (LTS) or '22' (Current). Alternatively, use 'lts/*' to automatically use the latest LTS version. |
||
| - run: npm ci | ||
| - run: npx tsc --noEmit | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,7 @@ jobs: | |
|
|
||
| - uses: actions/setup-node@v7 | ||
| with: | ||
| node-version: 22 | ||
| node-version: 24 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Use a supported version such as '20' (LTS) or '22' (Current). Alternatively, use 'node-version-file: .nvmrc' to sync with project configuration. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Revert to Node 22 (Active LTS) for the release workflow to ensure the publishing process runs on the most stable and widely supported platform. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Verify the intended Node.js version. Use Node 20 (Active LTS) or Node 22 (Current). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Use a valid Node.js version such as '20' (LTS) or '22' (Current). For release workflows, it is recommended to pin to an LTS version for stability. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [HIGH] correctness 💡 Use an Active LTS version (e.g., Node 22) for production releases to ensure compatibility and stability for downstream consumers, unless the library explicitly requires Node 24 features. |
||
| registry-url: https://registry.npmjs.org | ||
|
|
||
| - run: npm ci | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[HIGH] correctness
Node.js version 24 is not currently a stable release and is likely unavailable via actions/setup-node, causing the CI workflow to fail.
💡 Use a supported version such as '20' (LTS) or '22' (Current). Alternatively, use 'node-version-file: .nvmrc' to sync with project configuration.