Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,6 @@ jobs:
fetch-depth: 0
- uses: actions/setup-node@v7
with:
node-version: 20
node-version: 24

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Node.js version 24 is not currently a stable release and is likely unavailable via actions/setup-node, causing the CI workflow to fail.

💡 Use a supported version such as '20' (LTS) or '22' (Current). Alternatively, use 'node-version-file: .nvmrc' to sync with project configuration.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Upgraded Node.js from 20 to 24 (Current release) in CI. This removes testing coverage for Node 20 (Maintenance LTS) and introduces instability risks as dependencies may not yet support Node 24.

💡 Consider using a matrix strategy to test against multiple Node versions (e.g., 20, 22, and 24) or switch to Node 22 (Active LTS) to ensure stability while maintaining ecosystem compatibility.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Node.js version 24 is not an official stable release and is likely not supported by actions/setup-node, which will cause the CI workflow to fail.

💡 Verify the intended Node.js version. Use Node 20 (Active LTS) or Node 22 (Current).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Invalid Node.js version specified. Version 24 is not a stable release yet and will likely cause the actions/setup-node step to fail.

💡 Use a valid Node.js version such as '20' (LTS) or '22' (Current). Alternatively, use 'lts/*' to automatically use the latest LTS version.

- run: npm ci
- run: npx tsc --noEmit
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

- uses: actions/setup-node@v7
with:
node-version: 22
node-version: 24

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Node.js version 24 is not currently a stable release and is likely unavailable via actions/setup-node, causing the release workflow to fail.

💡 Use a supported version such as '20' (LTS) or '22' (Current). Alternatively, use 'node-version-file: .nvmrc' to sync with project configuration.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Upgraded Node.js from 22 to 24 (Current release) for releases. Publishing using a non-LTS version increases the risk of environment-specific failures and may produce artifacts incompatible with environments running Node 22.

💡 Revert to Node 22 (Active LTS) for the release workflow to ensure the publishing process runs on the most stable and widely supported platform.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Node.js version 24 is not an official stable release and is likely not supported by actions/setup-node, which will cause the release workflow to fail.

💡 Verify the intended Node.js version. Use Node 20 (Active LTS) or Node 22 (Current).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Invalid Node.js version specified. Version 24 is not a stable release yet and will likely cause the actions/setup-node step to fail.

💡 Use a valid Node.js version such as '20' (LTS) or '22' (Current). For release workflows, it is recommended to pin to an LTS version for stability.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[HIGH] correctness
Using non-LTS Node.js version (24) in the release workflow poses stability risks.

💡 Use an Active LTS version (e.g., Node 22) for production releases to ensure compatibility and stability for downstream consumers, unless the library explicitly requires Node 24 features.

registry-url: https://registry.npmjs.org

- run: npm ci
Expand Down
Loading