Bump to kind 0.31#2244
Conversation
skitt
requested review from
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr2244/skitt/kind-0.31 |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughUpdates kind from v0.30.0 to v0.31.0: refreshes kind 0.31.0 hashes in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
scripts/shared/lib/clusters_kind
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: E2E Consuming (submariner-operator, k8s-oldest-supported)
- GitHub Check: Package Documentation
- GitHub Check: Go
- GitHub Check: E2E Consuming (admiral, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (subctl, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner, wireguard)
- GitHub Check: Clean up generated files
- GitHub Check: E2E Consuming (submariner, libreswan, k8s-latest)
- GitHub Check: Images
- GitHub Check: E2E Consuming (lighthouse, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner-operator, libreswan, k8s-latest)
- GitHub Check: Latest Release to Latest Version
🔇 Additional comments (1)
scripts/shared/lib/clusters_kind (1)
28-33: Hashes partially verified—v1.31.14 confirmed from official kind releases.The SHA256 hash for Kubernetes v1.31.14 matches the official kind release notes. However, the v1.31.14 hash from official kind releases is 6f86cf509dbb42767b6e79debc3f2c32e4ee01386f0489b3b2be24b0a55aac2b, which corresponds to what's in the code. The hashes for v1.32.11, v1.33.7, v1.34.3, and v1.35.0 could not be verified against the official kind 0.31.0 release notes through available sources. Manual verification of these remaining hashes against the official kind releases is recommended.
| git clone -b kubeadm-v1beta4 https://github.com/skitt/ovn-kubernetes | ||
| pushd ovn-kubernetes || exit | ||
|
|
||
| # When updating commit, Update the OVN_SRC_IMAGE to the corressponding commit | ||
| git checkout 5115ef4c932eb689274d4e83bd065278d1b53e22 | ||
| git checkout ba4740204 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Find and examine the file containing the code
find . -name "clusters_kind" -type fRepository: submariner-io/shipyard
Length of output: 100
🏁 Script executed:
# Search for clusters_kind in the repository
fd clusters_kindRepository: submariner-io/shipyard
Length of output: 98
🏁 Script executed:
# Read the context around lines 300-310
sed -n '295,310p' scripts/shared/lib/clusters_kindRepository: submariner-io/shipyard
Length of output: 671
🏁 Script executed:
# Search for any TODO, FIXME, or issue references in the file around the fork section
grep -n -i "todo\|fixme\|issue\|tracking" scripts/shared/lib/clusters_kind | head -20Repository: submariner-io/shipyard
Length of output: 175
🏁 Script executed:
# Get the full OVN-related section to understand OVN_SRC_IMAGE usage
sed -n '290,320p' scripts/shared/lib/clusters_kindRepository: submariner-io/shipyard
Length of output: 1225
Add tracking for temporary fork usage and use full commit hash.
Per the commit message, this uses a personal fork of OVN-Kubernetes as a temporary measure. Add a TODO comment with an issue reference to track when this should be reverted to the upstream ovn-org/ovn-kubernetes repository.
Additionally, use the full 40-character commit SHA instead of the short hash ba4740204 to improve traceability and consistency with best practices.
🤖 Prompt for AI Agents
scripts/shared/lib/clusters_kind around lines 300-304: add a TODO comment above
the git clone noting this is a temporary personal fork and include a reference
to the tracking issue/PR to revert to the upstream ovn-org/ovn-kubernetes
repository (replace placeholder with the real issue/PR number), and replace the
short commit hash `ba4740204` with the full 40-character commit SHA (obtain the
full SHA from the repo or `git ls-remote` and update OVN_SRC_IMAGE accordingly)
so the clone/checkout uses the exact commit.
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (2)
scripts/shared/resources/kind-cluster-dual-stack-config.yaml (1)
16-16: Consistent API version update.Same v1beta3 update as in the other kind cluster configuration files.
scripts/shared/resources/kind-cluster-config.yaml (1)
15-15: Consistent API version update.Same v1beta3 update as in the other kind cluster configuration files.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
scripts/shared/resources/kind-cluster-config.yamlscripts/shared/resources/kind-cluster-dual-stack-config.yamlscripts/shared/resources/kind-cluster-ipv6-stack-config.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: E2E Consuming (admiral, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner-operator, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (lighthouse, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner-operator, k8s-oldest-supported)
- GitHub Check: E2E Consuming (subctl, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner, wireguard)
- GitHub Check: Clean up generated files
- GitHub Check: Images
- GitHub Check: Latest Release to Latest Version
- GitHub Check: Package Documentation
- GitHub Check: Go
| kubeadmConfigPatches: | ||
| - | | ||
| apiVersion: kubeadm.k8s.io/v1beta2 | ||
| apiVersion: kubeadm.k8s.io/v1beta3 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
kubeadm API version v1beta3 kubernetes 1.35 requirements compatibility
💡 Result:
Short answer: kubeadm config apiVersion v1beta3 is not compatible/supported for Kubernetes 1.35 — you must use the v1beta4 kubeadm configuration. [1][2][3]
Key points:
- v1beta3 is documented but was deprecated when kubeadm moved to v1beta4 in the v1.31 release. [2]
- The deprecation promised removal after a minimum of three minor releases; kubeadm v1beta4 is the recommended/target format for later releases. [2]
- Cluster API / support matrices list kubeadm API v1beta4 for Kubernetes v1.35. Migrate v1beta3 configs to v1beta4 for 1.35. [3]
References:
- kubeadm config v1beta3 reference. [1]
- Kubernetes blog: kubeadm v1beta4 (v1.31 deprecation of v1beta3). [2]
- Cluster-API version support matrix showing kubeadm API v1beta4 for Kubernetes v1.35. [3]
Change kubeadm apiVersion from v1beta3 to v1beta4 for Kubernetes 1.35 compatibility.
The kubeadm configuration API version v1beta3 is deprecated and not supported for Kubernetes 1.35. Version v1beta3 was deprecated in Kubernetes 1.31 with the introduction of v1beta4, which is now the required and recommended version for Kubernetes 1.35. Update line 16 to use apiVersion: kubeadm.k8s.io/v1beta4.
🤖 Prompt for AI Agents
In scripts/shared/resources/kind-cluster-ipv6-stack-config.yaml around line 16,
the kubeadm apiVersion is set to v1beta3 which is deprecated and incompatible
with Kubernetes 1.35; update the apiVersion value to kubeadm.k8s.io/v1beta4 so
the file uses the supported kubeadm API for K8s 1.35.
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/shared/resources/kind-cluster-ipv6-stack-config.yaml (1)
15-32: Remove the v1beta3 kubeadm patch (lines 15–23).The configuration defaults to Kubernetes 1.35, where kubeadm.k8s.io/v1beta3 is unsupported (deprecated in K8s 1.31, removed after 3 minor releases). The v1beta4 patch (lines 24–32) contains identical networking configuration and is the correct API version for K8s 1.35. Having both patches is redundant and risks subtle incompatibilities during kubeadm initialization. Keep only the v1beta4 patch.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
scripts/shared/resources/kind-cluster-config.yamlscripts/shared/resources/kind-cluster-dual-stack-config.yamlscripts/shared/resources/kind-cluster-ipv6-stack-config.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- scripts/shared/resources/kind-cluster-config.yaml
- scripts/shared/resources/kind-cluster-dual-stack-config.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: E2E Consuming (submariner, libreswan, k8s-latest)
- GitHub Check: Package Documentation
- GitHub Check: Go
- GitHub Check: E2E Consuming (subctl, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner, wireguard)
- GitHub Check: E2E Consuming (lighthouse, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner-operator, k8s-oldest-supported)
- GitHub Check: E2E Consuming (admiral, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (submariner-operator, libreswan, k8s-latest)
- GitHub Check: Clean up generated files
- GitHub Check: Images
- GitHub Check: Latest Release to Latest Version
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @scripts/shared/resources/kind-cluster-config.yaml:
- Around line 14-22: The kubeadm API version used in the ClusterConfiguration
block is outdated; update the apiVersion field in the ClusterConfiguration YAML
(the line showing "apiVersion: kubeadm.k8s.io/v1beta3") to "apiVersion:
kubeadm.k8s.io/v1beta4" so the ClusterConfiguration (kind: ClusterConfiguration)
is compatible with Kubernetes 1.35.
In @tools/go.mod:
- Line 8: The change bumps the kind dependency to sigs.k8s.io/kind v0.31.0 which
requires cgroup v2 support in node images; before merging, verify your runtime
and CI environments support cgroup v2 (or plan migration) and update any
docs/README or CI provisioning scripts to check/enable cgroup v2; if you cannot
guarantee cgroup v2 yet, hold the version bump or pin to the previous kind
version and add a TODO comment referencing the eventual upgrade and the kubeadm
v1beta3→v1beta4 breaking change for future kube versions.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
tools/go.sumis excluded by!**/*.sum
📒 Files selected for processing (8)
Makefile.clustersgh-actions/e2e/action.yamlpackage/Dockerfile.shipyard-dapper-basescripts/shared/lib/clusters_kindscripts/shared/resources/kind-cluster-config.yamlscripts/shared/resources/kind-cluster-dual-stack-config.yamlscripts/shared/resources/kind-cluster-ipv6-stack-config.yamltools/go.mod
🚧 Files skipped from review as they are similar to previous changes (6)
- gh-actions/e2e/action.yaml
- package/Dockerfile.shipyard-dapper-base
- scripts/shared/resources/kind-cluster-dual-stack-config.yaml
- scripts/shared/lib/clusters_kind
- Makefile.clusters
- scripts/shared/resources/kind-cluster-ipv6-stack-config.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)
- GitHub Check: E2E Consuming (submariner, libreswan, k8s-latest)
- GitHub Check: Package Documentation
- GitHub Check: E2E Consuming (submariner-operator, k8s-oldest-supported)
- GitHub Check: E2E Consuming (submariner, wireguard)
- GitHub Check: Go
- GitHub Check: E2E Consuming (submariner-operator, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (admiral, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (subctl, libreswan, k8s-latest)
- GitHub Check: E2E Consuming (lighthouse, libreswan, k8s-latest)
- GitHub Check: Clean up generated files
- GitHub Check: Images
- GitHub Check: Latest Release to Latest Version
🔇 Additional comments (1)
scripts/shared/resources/kind-cluster-config.yaml (1)
23-31: Clarify the intent of dual kubeadm API version patches.The configuration includes two identical kubeadmConfigPatches with different API versions (v1beta3 on lines 14-22 and v1beta4 on lines 23-31). While v1beta4 is supported in Kubernetes 1.35 and having multiple patches with different API versions is a valid pattern for supporting nodes running different kubeadm versions, the intent here should be documented. Please confirm:
- Whether this dual-patch approach intentionally supports both v1beta3 and v1beta4 kubeadm versions, or if one patch can be removed
- Any compatibility constraints that require maintaining both versions
| - | | ||
| apiVersion: kubeadm.k8s.io/v1beta2 | ||
| kind: ClusterConfiguration | ||
| apiVersion: kubeadm.k8s.io/v1beta3 | ||
| metadata: | ||
| name: config | ||
| networking: | ||
| podSubnet: ${pod_cidr} | ||
| serviceSubnet: ${service_cidr} | ||
| dnsDomain: ${dns_domain} |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
kubeadm API version v1beta3 Kubernetes 1.35 support
💡 Result:
Short answer: kubeadm API v1beta3 is not supported for Kubernetes v1.35 — use v1beta4. [1][2]
Supporting references:
- Official kubeadm v1beta3 docs (shows v1beta3 existed). [1]
- Kubernetes 1.31 release note: v1beta4 introduced and v1beta3 deprecated (removed after a minimum of three minor releases). [2]
- Cluster API support matrix: Kubernetes v1.35 → kubeadm API v1beta4. [3]
Update kubeadm API version from v1beta3 to v1beta4 for Kubernetes 1.35.
kubeadm API version v1beta3 is not supported in Kubernetes 1.35. v1beta3 was deprecated in Kubernetes 1.31 and removed from support after three minor releases. Change line 16 to use apiVersion: kubeadm.k8s.io/v1beta4.
🤖 Prompt for AI Agents
In @scripts/shared/resources/kind-cluster-config.yaml around lines 14 - 22, The
kubeadm API version used in the ClusterConfiguration block is outdated; update
the apiVersion field in the ClusterConfiguration YAML (the line showing
"apiVersion: kubeadm.k8s.io/v1beta3") to "apiVersion: kubeadm.k8s.io/v1beta4" so
the ClusterConfiguration (kind: ClusterConfiguration) is compatible with
Kubernetes 1.35.
| github.com/golangci/golangci-lint/v2 v2.7.2 | ||
| github.com/psampaz/go-mod-outdated v0.9.0 | ||
| sigs.k8s.io/kind v0.30.0 | ||
| sigs.k8s.io/kind v0.31.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
kind v0.31.0 Kubernetes compatibility release notes
💡 Result:
Summary of kind v0.31.0 Kubernetes compatibility (release highlights)
- Defaults to Kubernetes v1.35.0 (default node image: kindest/node:v1.35.0@sha256:452d707d...). [1][2]
- Kubernetes 1.35+ drops cgroup v1 support — kind node images at those Kubernetes versions likewise drop cgroup v1; migrate to cgroup v2 or use older Kubernetes if you must remain on cgroup v1. [2]
- kubeadm config: prepare for future move from kubeadm v1beta3 → v1beta4 (breaking change to extraArgs); if you use kubeadmConfigPatches, use versioned patches (v1beta3 and v1beta4) and adjust extraArgs shape as needed. kind currently uses v1beta3 for supported versions and is expected to adopt v1beta4 for a future Kubernetes (around 1.36+). [2]
- Installation/download notes reference v0.31.0 release binaries and go install target sigs.k8s.io/kind@v0.31.0. [1]
Sources: kind documentation (Quick Start / release info) and release notes for v0.31.0. [1] https://kind.sigs.k8s.io/docs/user/quick-start/ [2] release notes summary (v0.31.0).
🌐 Web query:
kind v0.31.0 security advisories CVE
💡 Result:
Short answer: There are no published CVEs that directly affect the kind v0.31.0 client itself. The v0.31.0 release is a dependency/update release (defaults to Kubernetes v1.35.0) and its release notes do not list any kind-specific CVEs. [1][2]
Notes & recommendations:
- kind node images can include components (containerd, runc, kernel, etc.) that have CVEs; check the exact node image(s) your clusters use (kindest/node:@sha256) and inspect those upstream component advisories. [1][2]
- Always review the kind releases page and the node image changelogs for security fixes before upgrading. [2]
Sources:
- kind project site / docs (v0.31.0 references). [1]
- kind v0.31.0 release notes / releases listing. [2]
🌐 Web query:
sigs.k8s.io kind v0.31.0 breaking changes
💡 Result:
Summary of breaking changes in sigs.k8s.io/kind v0.31.0
- Default node image bumped to kindest/node:v1.35.0 (digest changed). [1] (gitlab.com)
- Kubernetes 1.35+ drops cgroup v1 support — kind node images for those Kubernetes versions also drop cgroup v1; if you need cgroup v1, use older Kubernetes images or migrate to cgroup v2. [1] (gitlab.com)
- Warning about future kubeadm config change: kind will move to kubeadm v1beta4 (breaking change to kubeadm extraArgs) in a future release — prepare if you use kubeadmConfigPatches. [1] (gitlab.com)
- General note: this release contains dependency updates and defaults Kubernetes version; check release notes for any image- or runtime-related compatibility changes (containerd/cgroup/tooling) that may affect workflows. [2] (github.com)
Sources: [1] kind v0.31.0 release notes / changelog. [2] kind releases page. [1] (gitlab.com) [2] (github.com).
Citations:
- 1: https://gitlab.com/gitlab-com/gl-infra/observability/tenant-observability/config-manager/-/merge_requests/356?utm_source=openai
- 2: https://gitlab.com/gitlab-com/gl-infra/observability/tenant-observability/config-manager/-/merge_requests/356?utm_source=openai
- 3: https://gitlab.com/gitlab-com/gl-infra/observability/tenant-observability/config-manager/-/merge_requests/356?utm_source=openai
- 4: https://github.com/kubernetes-sigs/kind/releases?utm_source=openai
- 5: https://gitlab.com/gitlab-com/gl-infra/observability/tenant-observability/config-manager/-/merge_requests/356?utm_source=openai
- 6: https://github.com/kubernetes-sigs/kind/releases?utm_source=openai
Verify cgroup v2 compatibility before upgrading to kind v0.31.0.
kind v0.31.0 is compatible with Kubernetes 1.35.0 (which it defaults to) and has no security advisories. However, Kubernetes 1.35+ and kind v0.31.0's node images drop cgroup v1 support entirely. Ensure your environment supports cgroup v2 or plan to migrate to it before upgrading. Additionally, prepare for a future kubeadm configuration breaking change (v1beta3 → v1beta4) when kind adopts it for Kubernetes 1.36+.
🤖 Prompt for AI Agents
In @tools/go.mod at line 8, The change bumps the kind dependency to
sigs.k8s.io/kind v0.31.0 which requires cgroup v2 support in node images; before
merging, verify your runtime and CI environments support cgroup v2 (or plan
migration) and update any docs/README or CI provisioning scripts to check/enable
cgroup v2; if you cannot guarantee cgroup v2 yet, hold the version bump or pin
to the previous kind version and add a TODO comment referencing the eventual
upgrade and the kubeadm v1beta3→v1beta4 breaking change for future kube
versions.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
Release notes: https://github.com/kubernetes-sigs/kind/releases/tag/v0.31.0 Signed-off-by: Stephen Kitt <skitt@redhat.com>
dfarrell07
force-pushed
the
kind-0.31
branch
from
2ee777e to
f899ee2
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
|
🤖 Closed branches: [z_pr2244/skitt/kind-0.31] |
4 participants
This leaves the default Kubernetes version alone, because OVN doesn’t work with 1.35 yet.
Summary by CodeRabbit