Bump sigs.k8s.io/kind from 0.30.0 to 0.31.0 in /tools in the tools group#2246
Bump sigs.k8s.io/kind from 0.30.0 to 0.31.0 in /tools in the tools group#2246dependabot[bot] wants to merge 1 commit intodevelfrom
Conversation
Bumps the tools group in /tools with 1 update: [sigs.k8s.io/kind](https://github.com/kubernetes-sigs/kind). Updates `sigs.k8s.io/kind` from 0.30.0 to 0.31.0 - [Release notes](https://github.com/kubernetes-sigs/kind/releases) - [Commits](kubernetes-sigs/kind@v0.30.0...v0.31.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kind dependency-version: 0.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: tools ... Signed-off-by: dependabot[bot] <support@github.com>
|
@coderabbitai review |
WalkthroughThe pull request updates the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Pre-merge checksCaution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (2 passed)
Comment |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
tools/go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
tools/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Images
- GitHub Check: Go
- GitHub Check: Clean up generated files
- GitHub Check: Package Documentation
- GitHub Check: Latest Release to Latest Version
🔇 Additional comments (1)
tools/go.mod (1)
8-8: kind v0.31.0 is compatible for immediate use; prepare kubeadmConfigPatches for future v1beta4 migration.kind v0.31.0 updates the default Kubernetes version to v1.35.0, which removes cgroup v1 support, but this is not a concern as the codebase has no cgroup v1 references and most stable Linux distributions support cgroup v2 out of the box. kind uses kubeadm v1beta3 for Kubernetes 1.23+ and will likely use v1beta4 for Kubernetes 1.36+, so shipyard's current kubeadmConfigPatches remain compatible with v0.31.0. When kind eventually adopts v1beta4, use versioned config patches that explicitly match the version required; v1beta3 uses string/string maps for extraArgs while v1beta4 uses lists of name/value pairs.
| github.com/golangci/golangci-lint/v2 v2.7.2 | ||
| github.com/psampaz/go-mod-outdated v0.9.0 | ||
| sigs.k8s.io/kind v0.30.0 | ||
| sigs.k8s.io/kind v0.31.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Search shipyard codebase for kubeadmConfigPatches and kind cluster configurations
echo "=== Searching for kubeadmConfigPatches ==="
find . -type f \( -name "*.go" -o -name "*.yaml" -o -name "*.yml" -o -name "*.sh" \) | head -20 | xargs grep -l "kubeadmConfigPatches" 2>/dev/null || echo "No files with kubeadmConfigPatches found"
echo -e "\n=== Searching for kind cluster config files ==="
find . -type f \( -name "*kind*config*" -o -name "*cluster*.yaml" -o -name "*cluster*.yml" \) | head -20
echo -e "\n=== Searching for extraArgs in configuration files ==="
grep -r "extraArgs" --include="*.yaml" --include="*.yml" --include="*.go" . 2>/dev/null | head -20 || echo "No extraArgs found"
echo -e "\n=== Checking for cgroup-specific configurations ==="
grep -ri "cgroup" . --include="*.go" --include="*.sh" --include="*.yaml" 2>/dev/null | head -20 || echo "No cgroup configurations found"Repository: submariner-io/shipyard
Length of output: 653
🏁 Script executed:
#!/bin/bash
# List the directory structure to understand the repo layout
echo "=== Repository structure ==="
ls -la
echo -e "\n=== Searching for kind-related configurations ==="
find . -type f \( -name "*.yaml" -o -name "*.yml" \) | xargs grep -l "kind.*Cluster\|kubeadmConfigPatches" 2>/dev/null || echo "No kind cluster configs found"
echo -e "\n=== Searching Go code for kind usage ==="
find . -name "*.go" -type f | xargs grep -l "kubeadmConfigPatches\|extraArgs" 2>/dev/null | head -10 || echo "No Go files with relevant code found"Repository: submariner-io/shipyard
Length of output: 3567
🏁 Script executed:
#!/bin/bash
echo "=== kind-cluster-config.yaml ==="
cat ./scripts/shared/resources/kind-cluster-config.yaml
echo -e "\n=== kind-cluster-dual-stack-config.yaml ==="
cat ./scripts/shared/resources/kind-cluster-dual-stack-config.yaml | head -30Repository: submariner-io/shipyard
Length of output: 1412
Update kubeadmConfigPatches from v1beta2 to v1beta3 and prepare v1beta4 variants for kind v0.31.0.
Kind v0.31.0 uses kubeadm v1beta3 for Kubernetes 1.23+ (including the default v1.35.0), but the kind cluster config files specify the obsolete v1beta2 API version. Kind no longer tests or actively supports v1beta2. Update kind-cluster-config.yaml and kind-cluster-dual-stack-config.yaml to use apiVersion: kubeadm.k8s.io/v1beta3.
Additionally, kind will likely use v1beta4 for Kubernetes 1.36+. Provide versioned config patches for both v1beta3 and v1beta4 to ensure future compatibility.
Also verify cgroup v2 environment support: Kind v0.31.0 defaults to Kubernetes v1.35.0, which removes cgroup v1 support.
🤖 Prompt for AI Agents
In tools/go.mod around line 8, update the kind-related cluster config files to
replace kubeadmConfigPatches apiVersion v1beta2 with kubeadm.k8s.io/v1beta3 and
add parallel kubeadm.k8s.io/v1beta4 variants for future Kubernetes 1.36+
compatibility: modify kind-cluster-config.yaml and
kind-cluster-dual-stack-config.yaml to use apiVersion: kubeadm.k8s.io/v1beta3,
create corresponding v1beta4 patch files or variants (same content but
apiVersion: kubeadm.k8s.io/v1beta4), and ensure any code/CI that references the
old v1beta2 filenames or keys is updated; lastly, add a note or check in the
setup/docs/CI to verify cgroup v2 support (or detect cgroup v2 and fail fast)
because kind v0.31.0 defaults to Kubernetes v1.35 which drops cgroup v1 support.
|
Handled in #2244 @dependabot ignore this patch version |
|
@dependabot ignore sigs.k8s.io/kind patch version |
Pull request was closed
|
OK, I won't notify you about version 0.31.0 of sigs.k8s.io/kind again, unless you unignore it. |
Bumps the tools group in /tools with 1 update: sigs.k8s.io/kind.
Updates
sigs.k8s.io/kindfrom 0.30.0 to 0.31.0Release notes
Sourced from sigs.k8s.io/kind's releases.
... (truncated)
Commits
a323333version v0.31.032124c6Merge pull request #4077 from BenTheElder/135b088420drop almalinux 8b1b15edbump node image to 1.35.0c17c183Merge pull request #4069 from BenTheElder/latest-images36ee7a6update node image to 1.34.3 with runc 1.2.x1f8526cMerge pull request #4073 from aoxn/typoa47cf1elicense typo57ed4dause base image with runc 1.2.x5e1c871downgrade runc to 1.2.9 due to broken Kubernetes 1.33 testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.