Skip to content

Fix FileNotFoundException due to race in NativeFileSorter #5921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subhramit wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −13
Open

Fix FileNotFoundException due to race in NativeFileSorter #5921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions scio-extra/src/main/scala/com/spotify/scio/extra/sorter/syntax/SCollectionSyntax.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,20 +70,13 @@ final class SorterOps[K1, K2: SortingKey, V](self: SCollection[(K1, Iterable[(K2
.applyTransform(SortValues.create[K1, K2, V](options))(coder)
.withName("KvToTuple")
.map { kv =>
val iter = new Iterable[(K2, V)] {
override def iterator: Iterator[(K2, V)] = new AbstractIterator[(K2, V)] {
private[this] val iter = kv.getValue.iterator()
override def hasNext: Boolean = iter.hasNext

override def next(): (K2, V) = {
val next = iter.next()
(next.getKey, next.getValue)
}
}

override def toString: String = "<iterable>"
val iter = kv.getValue.iterator()
val buf = Vector.newBuilder[(K2, V)]
while (iter.hasNext) {
val next = iter.next()
buf += ((next.getKey, next.getValue))
}
(kv.getKey, iter)
(kv.getKey, buf.result(): Iterable[(K2, V)])
}(Coder.beam(c.internal.getCoder))
}
}
Expand Down