Fix FileNotFoundException due to race in NativeFileSorter#5921
Open
subhramit wants to merge 1 commit intospotify:mainfrom
Open
Fix FileNotFoundException due to race in NativeFileSorter#5921subhramit wants to merge 1 commit intospotify:mainfrom
FileNotFoundException due to race in NativeFileSorter#5921subhramit wants to merge 1 commit intospotify:mainfrom
Conversation
Signed-off-by: subhramit <subhramit.bb@live.in>
FileNotFoundException due to race in NativeFileSorter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5765
The bug apparently was a race due to the lazy iterator escaping its DoFn's lifecycle.
The flow goes -
SortValuesinternally wrote spilled data to temp filesSortValuesDoFndeleted those temp files when it finished processing the element (end of@ProcessElement)KvToTuplemap returns a lazyIterable[(K2, V)]that wrapped theDecodingIterableList.prependedAllcalled.iteratoron the lazy wrapper after the DoFn has already cleaned up the temp files, causing theFileNotFoundExceptionFix was simply to force full consumption of the
DecodingIterablewhile the DoFn is still alive and the temp files still exist.Now by the time
.mapreturns a(K1, Iterable[(K2, V)]), the Iterable is a plain Scala Vector with no references to Beam internals or temp files.