Skip to content

Correct formatting tests to match latest pygments - #14669

Closed
clayote wants to merge 2 commits into
sphinx-doc:masterfrom
clayote:test-data
Closed

clayote wants to merge 2 commits into
sphinx-doc:masterfrom
clayote:test-data

Conversation

@clayote

@clayote clayote commented Sep 10, 2026 •

Copy link
Copy Markdown

As of version 2.21.0, pygments doesn't escape quotation marks, single or double, when they appear between span tags like
<span>"Hello sphinx world"</span>.
This PR updates the test data to match the new behavior.

Purpose

References

AI Disclosure

No AI tools used

@clayote
clayote marked this pull request as draft September 10, 2026 19:02
@clayote

clayote commented Sep 10, 2026

Copy link
Copy Markdown
Author

It occurs to me that Sphinx might want to support older versions of pygments?

As of version 2.21.0, pygments doesn't escape quotation marks
when they appear between span tags like
`<span>"Hello sphinx world"</span>`.
This commit updates the test data to match the new behavior.

pygments/pygments#3185
@clayote

clayote commented Sep 10, 2026

Copy link
Copy Markdown
Author

Well, I guess the Docutils HEAD tests are broken regardless

@clayote
clayote marked this pull request as ready for review September 10, 2026 23:57
@hugovk

hugovk commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

See also PR #14611.

@clayote

clayote commented Sep 11, 2026

Copy link
Copy Markdown
Author

Ok, that's a better approach

@clayote clayote closed this Sep 11, 2026
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Oct 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants