Repository navigation
Conversation
80bf130 to
d02b33f
Compare
jdillard
left a comment
There was a problem hiding this comment.
Looks good to me. This is non-blocking, but the existing verbosity 0 and verbosity 1 tests strip ANSI escapes, so they don’t guard the new color bands against regressions. I'm not sure if it would be worth adding a focused color assertion, but I’ll leave that judgment to you.
There is also merge conflict at this time, but it looks straightforward to fix.
|
I find the color coding a bit confusing. Red to green scales are typically related to quality (was there a warning or error?) not to progress. Would it be more appropriate to introduce progress bars instead? |
|
This is a fair point, starting off with a bunch of red could be concerning to a user. |
|
I've updated it to a scale from grey -> blue -> turquoise -> teal -> green. How's this look? |
|
Since this is UX, I feel like this would be easiest to review with an asciinema demo or similar |
|
Here you go: https://asciinema.org/a/0orjLfcsaUc5MfXj (will be automatically deleted after seven days). Or download and unzip sphinx-build.cast.zip then: brew install asciinema # for macOS
asciinema play sphinx-build.castOr to test locally: gh co 14670
uv run --group docs --no-group package make -C doc clean html |
Purpose
Add more colour to the logs, so the "[XX%]" bit is shown in a different colour based on percentage, from red to green:
Demo using:
I verified no colour is shown when disabling via env var:
AI Disclosure
Initial code by Claude, improved by me.