Skip to content

test: Fix try_from_system_time_to_file_time_before_nt_time_epoch #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorairolake merged 1 commit into from
Mar 6, 2026
Merged

test: Fix try_from_system_time_to_file_time_before_nt_time_epoch #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/CI.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
os: windows-2025
target: x86_64-pc-windows-msvc
- toolchain-alias: msrv
toolchain: 1.93.0
toolchain: 1.94.0
- toolchain-alias: stable
toolchain: stable
steps:
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
os: windows-2025
target: x86_64-pc-windows-msvc
- toolchain-alias: msrv
toolchain: 1.93.0
toolchain: 1.94.0
- toolchain-alias: stable
toolchain: stable
steps:
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ All notable changes to this project will be documented in this file.
The format is based on https://keepachangelog.com/[Keep a Changelog], and this
project adheres to https://semver.org/[Semantic Versioning].

== {compare-url}/v0.15.0\...HEAD[Unreleased]

=== Changed

* Bump MSRV to 1.94.0 ({pull-request-url}/461[#461])

== {compare-url}/v0.14.0\...v0.15.0[0.15.0] - 2026-02-28

=== Changed
Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
name = "nt-time"
version = "0.15.0"
edition = "2024"
rust-version = "1.93.0"
rust-version = "1.94.0"
description = "A Windows file time library"
documentation = "https://docs.rs/nt-time"
repository = "https://github.com/sorairolake/nt-time"
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ See the [documentation][docs-url] for more details.

## Minimum supported Rust version

The minimum supported Rust version (MSRV) of this library is v1.93.0.
The minimum supported Rust version (MSRV) of this library is v1.94.0.

## Source code

Expand Down
10 changes: 5 additions & 5 deletions src/file_time/convert.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,9 +263,10 @@ impl TryFrom<SystemTime> for FileTime {
/// );
///
/// // Before `1601-01-01 00:00:00 UTC`.
/// #[cfg(not(windows))]
/// assert!(
/// FileTime::try_from(
/// SystemTime::UNIX_EPOCH - Duration::from_nanos(11_644_473_600_000_000_100)
/// SystemTime::UNIX_EPOCH - Duration::from_nanos(11_644_473_600_000_000_001)
/// )
/// .is_err()
/// );
Expand Down Expand Up @@ -711,14 +712,13 @@ mod tests {
}

#[cfg(feature = "std")]
#[cfg(not(windows))]
#[test]
fn try_from_system_time_to_file_time_before_nt_time_epoch() {
assert_eq!(
FileTime::try_from(if cfg!(windows) {
SystemTime::UNIX_EPOCH - Duration::from_nanos(11_644_473_600_000_000_100)
} else {
FileTime::try_from(
SystemTime::UNIX_EPOCH - Duration::from_nanos(11_644_473_600_000_000_001)
})
)
.unwrap_err(),
FileTimeRangeErrorKind::Negative.into()
);
Expand Down