test: Fix try_from_system_time_to_file_time_before_nt_time_epoch#461
Merged
sorairolake merged 1 commit intodevelopfrom Mar 6, 2026
Merged
test: Fix try_from_system_time_to_file_time_before_nt_time_epoch#461sorairolake merged 1 commit intodevelopfrom
try_from_system_time_to_file_time_before_nt_time_epoch#461sorairolake merged 1 commit intodevelopfrom
Conversation
Since Rust 1.94.0, the minimum value of `SystemTime` on Windows is guaranteed to be `FileTime::NT_TIME_EPOCH`. So I fix this test to not run on Windows.
sorairolake
force-pushed
the
fix-system-time-on-windows
branch
from
8625e80 to
3362a98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows
std::time::SystemTime::checked_sub_durationwill returnNonefor times before the NT time epoch.See rust-lang/rust#148825
Closes #
Additional context
Checklist