-
Notifications
You must be signed in to change notification settings - Fork 0
feat/#22: start, continue comment 뷰 구현 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
921a705
feat: start comment 뷰 구현
sung-silver 44e42e3
feat: continue 페이지 구현
sung-silver 89bcf9c
feat: PeerCommentRepeater 추가 버튼 활성화 기준 추가
sung-silver 1eb2997
feat: 멤버 선택 모달에서 멤버를 1명 이상 선택해야지만 확인 완료 버튼이 활성화되도록 변경
sung-silver f23c835
refactor: 코드 리뷰 반영
sung-silver 2f29431
refactor: peer_comment 뷰에서 사용되는 데이터 상수로 분리
sung-silver d88c2e6
feat: dialog를 botomsheet로 변경
sung-silver 06daaf1
feat: Next 버튼 비활성화 로직 제거
sung-silver 0ec6546
refactor: 코드리뷰 반영
sung-silver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import stopCommentExample from '@assets/stop_comment_example.svg'; | ||
| import stopCommentExplanation from '@assets/stop_comment_explanation.svg'; | ||
| import startCommentExample from '@assets/start_comment_example.svg'; | ||
| import startCommentExplanation from '@assets/start_comment_explanation.svg'; | ||
| import continueCommentExample from '@assets/continue_comment_example.svg'; | ||
| import continueCommentExplanation from '@assets/continue_comment_explanation.svg'; | ||
| import type { PeerCommentStepContent } from '@types'; | ||
|
|
||
| export const STOP_COMMENT_STEP_CONTENT: PeerCommentStepContent = { | ||
| commentKey: 'stop_comments', | ||
| title: 'Stop 코멘트 작성', | ||
| description: '이번 스프린트에서 협업하며 그만했으면 하는 점에 대해 전달해요.', | ||
| guideImages: [stopCommentExplanation, stopCommentExample], | ||
| sectionTitle: 'Stop Comment를 전달하고 싶은 동료', | ||
| questionLabel: '해당 동료가 그만했으면 하는 점은 무엇인가요?', | ||
| textPlaceholder: '그만했으면 하는 점', | ||
| }; | ||
|
|
||
| export const START_COMMENT_STEP_CONTENT: PeerCommentStepContent = { | ||
| commentKey: 'start_comments', | ||
| title: 'Start 코멘트 작성', | ||
| description: '이번 스프린트에서 협업하며 시작했으면 하는 점에 대해 전달해요.', | ||
| guideImages: [startCommentExplanation, startCommentExample], | ||
| sectionTitle: 'Start Comment를 전달하고 싶은 동료', | ||
| questionLabel: '해당 동료가 시작했으면 하는 점은 무엇인가요?', | ||
| textPlaceholder: '시작했으면 하는 점', | ||
| }; | ||
|
|
||
| export const CONTINUE_COMMENT_STEP_CONTENT: PeerCommentStepContent = { | ||
| commentKey: 'continue_comments', | ||
| title: 'Continue 코멘트 작성', | ||
| description: '이번 스프린트에서 협업하며 계속했으면 하는 점에 대해 전달해요.', | ||
| guideImages: [continueCommentExplanation, continueCommentExample], | ||
| sectionTitle: 'Continue Comment를 전달하고 싶은 동료', | ||
| questionLabel: '해당 동료가 계속했으면 하는 점은 무엇인가요?', | ||
| textPlaceholder: '계속했으면 하는 점', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import { PeerCommentStepTemplate } from '@components'; | ||
| import { CONTINUE_COMMENT_STEP_CONTENT } from '../constant/peerCommentStepContents'; | ||
|
|
||
| function ContinueCommentPage() { | ||
| return ( | ||
| <PeerCommentStepTemplate | ||
| content={CONTINUE_COMMENT_STEP_CONTENT} | ||
| currentStep={4} | ||
| nextPath="/next" | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| export default ContinueCommentPage; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.