feat/#22: start, continue comment 뷰 구현#23
Merged
sung-silver merged 9 commits intodevelopfrom Apr 18, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
Summary by CodeRabbit
Walkthrough라우터에 Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/peer-comment/PeerCommentRepeater.tsx (1)
33-58:⚠️ Potential issue | 🟡 Minor공백만 입력된 경우
추가버튼이 잘못 활성화됩니다.Line 33에서
row.text.length === 0만 검사하면' '같은 공백 입력이 유효 텍스트처럼 처리됩니다. 그 결과 Line 58의disabled가false가 되어, 실제로는 미완성 행인데도 추가가 가능해집니다.수정 제안
- const isAddDisabled = rows.some((row) => row.memberIds.length === 0 || row.text.length === 0); + const isAddDisabled = rows.some((row) => row.memberIds.length === 0 || row.text.trim().length === 0);🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/peer-comment/PeerCommentRepeater.tsx` around lines 33 - 58, The disabled check allows whitespace-only text because it uses row.text.length === 0; update the isAddDisabled computation to treat whitespace as empty by trimming the text (e.g., replace the check with something like (row.memberIds.length === 0 || (row.text || '').trim().length === 0)). Locate the isAddDisabled variable and change the row.text length test to use .trim() (and guard against null/undefined) so the Add Button (disabled prop) correctly disables for whitespace-only input.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@src/components/peer-comment/PeerCommentRepeater.tsx`:
- Around line 33-58: The disabled check allows whitespace-only text because it
uses row.text.length === 0; update the isAddDisabled computation to treat
whitespace as empty by trimming the text (e.g., replace the check with something
like (row.memberIds.length === 0 || (row.text || '').trim().length === 0)).
Locate the isAddDisabled variable and change the row.text length test to use
.trim() (and guard against null/undefined) so the Add Button (disabled prop)
correctly disables for whitespace-only input.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 20bb9971-0442-4857-bfc6-82de3f2dd7cb
⛔ Files ignored due to path filters (4)
src/assets/continue_comment_example.svgis excluded by!**/*.svgsrc/assets/continue_comment_explanation.svgis excluded by!**/*.svgsrc/assets/start_comment_example.svgis excluded by!**/*.svgsrc/assets/start_comment_explanation.svgis excluded by!**/*.svg
📒 Files selected for processing (6)
src/App.tsxsrc/components/peer-comment/PeerCommentRepeater.tsxsrc/components/peer-comment/PeerMemberPicker.tsxsrc/pages/ContinueCommentPage.tsxsrc/pages/StartCommentPage.tsxsrc/pages/StopCommentPage.tsx
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/peer-comment/PeerMemberPicker.css.ts`:
- Around line 30-39: The current globalStyle selector using body >
div:has(.${sheetDialogSurface}) is too broad and can match the app root; update
PeerMemberPicker.css.ts to scope styles to the actual sheet element instead of
its ancestor—e.g., target the sheetDialogSurface class/identifier itself or a
stable slot/prop provided by BottomSheetContent (refer to sheetDialogSurface and
PeerMemberPicker.tsx where BottomSheetContent is used), or add a unique wrapper
class on the sheet instance and apply styles to that class so
width/maxWidth/backgroundColor/transform only affect the sheet element.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0beb6173-ca6b-499e-a4f1-b090b9b99157
📒 Files selected for processing (12)
src/components/index.tssrc/components/peer-comment/PeerCommentBlock.tsxsrc/components/peer-comment/PeerCommentRepeater.tsxsrc/components/peer-comment/PeerCommentStepTemplate.tsxsrc/components/peer-comment/PeerMemberPicker.css.tssrc/components/peer-comment/PeerMemberPicker.tsxsrc/constant/peerCommentStepContents.tssrc/pages/ContinueCommentPage.tsxsrc/pages/StartCommentPage.tsxsrc/pages/StopCommentPage.tsxsrc/types/comment.tssrc/types/index.ts
✅ Files skipped from review due to trivial changes (5)
- src/types/index.ts
- src/components/peer-comment/PeerCommentBlock.tsx
- src/pages/ContinueCommentPage.tsx
- src/types/comment.ts
- src/constant/peerCommentStepContents.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- src/components/peer-comment/PeerCommentRepeater.tsx
- src/pages/StopCommentPage.tsx
- src/components/peer-comment/PeerMemberPicker.tsx
- src/pages/StartCommentPage.tsx
yungu0010
pushed a commit
that referenced
this pull request
Apr 18, 2026
* feat: start comment 뷰 구현 * feat: continue 페이지 구현 * feat: PeerCommentRepeater 추가 버튼 활성화 기준 추가 * feat: 멤버 선택 모달에서 멤버를 1명 이상 선택해야지만 확인 완료 버튼이 활성화되도록 변경 * refactor: 코드 리뷰 반영 * refactor: peer_comment 뷰에서 사용되는 데이터 상수로 분리 * feat: dialog를 botomsheet로 변경 * feat: Next 버튼 비활성화 로직 제거 * refactor: 코드리뷰 반영
yungu0010
pushed a commit
that referenced
this pull request
Apr 21, 2026
* feat: start comment 뷰 구현 * feat: continue 페이지 구현 * feat: PeerCommentRepeater 추가 버튼 활성화 기준 추가 * feat: 멤버 선택 모달에서 멤버를 1명 이상 선택해야지만 확인 완료 버튼이 활성화되도록 변경 * refactor: 코드 리뷰 반영 * refactor: peer_comment 뷰에서 사용되는 데이터 상수로 분리 * feat: dialog를 botomsheet로 변경 * feat: Next 버튼 비활성화 로직 제거 * refactor: 코드리뷰 반영
yungu0010
pushed a commit
that referenced
this pull request
Apr 21, 2026
* feat: start comment 뷰 구현 * feat: continue 페이지 구현 * feat: PeerCommentRepeater 추가 버튼 활성화 기준 추가 * feat: 멤버 선택 모달에서 멤버를 1명 이상 선택해야지만 확인 완료 버튼이 활성화되도록 변경 * refactor: 코드 리뷰 반영 * refactor: peer_comment 뷰에서 사용되는 데이터 상수로 분리 * feat: dialog를 botomsheet로 변경 * feat: Next 버튼 비활성화 로직 제거 * refactor: 코드리뷰 반영
This was referenced Apr 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue 🚀
Work Description ✏️
PR Point 📸
2026-04-15.10.57.53.mov