Skip to content

fix(a11y): add aria-label to Data Table filter inputs #10421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xyaz1313 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): add aria-label to Data Table filter inputs #10421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/v4/app/(app)/examples/tasks/components/data-table-toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export function DataTableToolbar<TData>({
<div className="flex items-center justify-between">
<div className="flex flex-1 items-center gap-2">
<Input
aria-label="Filter tasks"
placeholder="Filter tasks..."
value={(table.getColumn("title")?.getFilterValue() as string) ?? ""}
onChange={(event) =>
Expand Down
1 change: 1 addition & 0 deletions apps/v4/examples/base/data-table-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ export function DataTableDemo() {
<div className="w-full">
<div className="flex items-center py-4">
<Input
aria-label="Filter emails"
placeholder="Filter emails..."
value={(table.getColumn("email")?.getFilterValue() as string) ?? ""}
onChange={(event) =>
Expand Down
1 change: 1 addition & 0 deletions apps/v4/examples/radix/data-table-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ export function DataTableDemo() {
<div className="w-full">
<div className="flex items-center py-4">
<Input
aria-label="Filter emails"
placeholder="Filter emails..."
value={(table.getColumn("email")?.getFilterValue() as string) ?? ""}
onChange={(event) =>
Expand Down