fix(a11y): add aria-label to Data Table filter inputs#10421
Open
xyaz1313 wants to merge 1 commit intoshadcn-ui:mainfrom
Open
fix(a11y): add aria-label to Data Table filter inputs#10421xyaz1313 wants to merge 1 commit intoshadcn-ui:mainfrom
xyaz1313 wants to merge 1 commit intoshadcn-ui:mainfrom
Conversation
Adds missing aria-label attributes to filter inputs in all Data Table example variants (Radix, Base, and Tasks) to fix WCAG 2.1 SC 4.1.2 violation. Fixes shadcn-ui#10397
Contributor
|
@xyaz1313 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing
aria-labelattributes to filter inputs in all Data Table example variants (Radix, Base, and Tasks) to fix a WCAG 2.1 SC 4.1.2 violation.Issue
Fixes #10397
Changes
apps/v4/examples/radix/data-table-demo.tsx— Addedaria-label="Filter emails"to the filter inputapps/v4/examples/base/data-table-demo.tsx— Addedaria-label="Filter emails"to the filter inputapps/v4/app/(app)/examples/tasks/components/data-table-toolbar.tsx— Addedaria-label="Filter tasks"to the filter inputWhy this matters
Since developers copy these examples directly into their projects, missing accessible labels propagate to thousands of production applications. Adding
aria-labelensures screen reader users understand the purpose of these filter inputs.Testing
aria-labelattribute added