Remove unused spans from AttributeKind by mejrs · Pull Request #156065 · rust-lang/rust

mejrs · 2026-05-01T21:10:35Z

Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.

rustbot · 2026-05-01T21:10:37Z

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in coverage instrumentation.

cc @Zalathar

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

The Clippy subtree was changed

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-05-01T21:10:40Z

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 20 candidates

JonathanBrouwer · 2026-05-01T21:15:03Z

@bors try @rust-timer queue

Remove unused spans from AttributeKind

rust-bors · 2026-05-01T23:22:41Z

☀️ Try build successful (CI)
Build commit: 54e80b0 (54e80b014e9516914bee6af96045039078e5ca91, parent: 67bcaa9c4b1b1015efae3d591155c79760b1e0a5)

rust-timer · 2026-05-02T00:20:30Z

Finished benchmarking commit (54e80b0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.6%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.6%	[3.6%, 3.6%]	1
Regressions ❌ (secondary)	1.8%	[0.4%, 3.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[3.6%, 3.6%]	1

Cycles

Results (secondary 5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	26.7%	[2.7%, 50.7%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.8%, -0.4%]	7
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.1%, -0.0%]	33
Improvements ✅ (secondary)	-0.1%	[-0.6%, -0.0%]	43
All ❌✅ (primary)	-0.0%	[-0.1%, -0.0%]	33

Bootstrap: 487.864s -> 482.272s (-1.15%)
Artifact size: 390.99 MiB -> 390.92 MiB (-0.02%)

JonathanBrouwer

@bors r+ rollup

View changes since this review

rust-bors · 2026-05-02T07:22:12Z

📌 Commit 9a23b67 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 9 pull requests Successful merges: - #156030 (Make stable hashing names consistent (part 1)) - #156020 (Improve source code for `librustdoc/visit_ast.rs`) - #156021 (Clean up some traits) - #156028 (Add a `Local::arg(i)` helper constructor) - #156037 (Add AcceptContext::expect_no_args) - #156040 (Add missing alias to mailmap) - #156048 (Make `diverging_type_vars` a vec of `TyVid`) - #156053 (Reuse CTFE MIR for constructors.) - #156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind)

rustbot · 2026-05-02T15:41:43Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-05-02T15:51:53Z

@bors r+

rust-bors · 2026-05-02T15:51:57Z

📌 Commit 4a13f36 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Remove unused spans from AttributeKind Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.

…uwer Rollup of 5 pull requests Successful merges: - #152277 (Validate source snippet when format input is raw string) - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind) - #156079 (Move and rename the `clone-never.rs` test) - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)

Rollup of 5 pull requests Successful merges: - #155666 (Interning cleanups) - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind) - #156079 (Move and rename the `clone-never.rs` test) - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)

Rollup merge of #156065 - mejrs:spanculler, r=JonathanBrouwer Remove unused spans from AttributeKind Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.

…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#156030 (Make stable hashing names consistent (part 1)) - rust-lang/rust#156020 (Improve source code for `librustdoc/visit_ast.rs`) - rust-lang/rust#156021 (Clean up some traits) - rust-lang/rust#156028 (Add a `Local::arg(i)` helper constructor) - rust-lang/rust#156037 (Add AcceptContext::expect_no_args) - rust-lang/rust#156040 (Add missing alias to mailmap) - rust-lang/rust#156048 (Make `diverging_type_vars` a vec of `TyVid`) - rust-lang/rust#156053 (Reuse CTFE MIR for constructors.) - rust-lang/rust#156059 (compiler: Print valid `-Zmir-enable-passes` names if invalid name is used) Failed merges: - rust-lang/rust#155940 (refactor rustc_on_unimplemented's filtering) - rust-lang/rust#156065 (Remove unused spans from AttributeKind)

1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match. rust-lang/rust#156030 2. `rustc_hir::attrs::AttributeKind::NoStd` is now fieldless. rust-lang/rust#156065 PiperOrigin-RevId: 910142545

1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match. rust-lang/rust#156030 2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless. rust-lang/rust#156065 PiperOrigin-RevId: 910142545

1. The `HashStable` trait was renamed to `StableHash`, and its method was also renamed to match. rust-lang/rust#156030 2. `rustc_hir::attrs::AttributeKind::{NoStd, NoCore}` are now fieldless. rust-lang/rust#156065 PiperOrigin-RevId: 910219736

rustbot assigned oli-obk May 1, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 1, 2026

rust-bors Bot pushed a commit that referenced this pull request May 1, 2026

Auto merge of #156065 - mejrs:spanculler, r=<try>

54e80b0

Remove unused spans from AttributeKind

JonathanBrouwer assigned JonathanBrouwer and unassigned oli-obk May 1, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 2, 2026

JonathanBrouwer approved these changes May 2, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2026

This was referenced May 2, 2026

Rollup of 7 pull requests #156076

Closed

Rollup of 9 pull requests #156078

Merged

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 2, 2026

This comment has been minimized.

Sign in to view

mejrs added 2 commits May 2, 2026 17:33

remove unused diagnostic attr spans

1cd3a3d

Remove more spans from AttributeKind

4a13f36

mejrs force-pushed the spanculler branch from 9a23b67 to 4a13f36 Compare May 2, 2026 15:41

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2026

JonathanBrouwer mentioned this pull request May 2, 2026

Rollup of 5 pull requests #156094

Closed

JonathanBrouwer mentioned this pull request May 2, 2026

Rollup of 5 pull requests #156095

Closed

jhpratt mentioned this pull request May 3, 2026

Rollup of 5 pull requests #156097

Merged

rust-bors Bot merged commit c3afa21 into rust-lang:main May 3, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 3, 2026

copybara-service Bot mentioned this pull request May 4, 2026

Adapt to unstable rustc API changes google/crubit#949

Merged

Uh oh!

Conversation

mejrs commented May 1, 2026

Uh oh!

rustbot commented May 1, 2026

Uh oh!

rustbot commented May 1, 2026

Uh oh!

JonathanBrouwer commented May 1, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 1, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 2, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented May 2, 2026

Uh oh!

This comment has been minimized.

rustbot commented May 2, 2026

Uh oh!

JonathanBrouwer commented May 2, 2026

Uh oh!

rust-bors Bot commented May 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JonathanBrouwer left a comment •

edited by rustbot

Loading