Rollup of 5 pull requests#156094
Closed
JonathanBrouwer wants to merge 15 commits intorust-lang:mainfrom
Closed
Conversation
…hlin miri: require (almost) all 1-ZST arguments to be actually passed We can't ignore *all* of them since the compiler itself relies on non-capturing closure arguments being ignored. Fixes rust-lang/miri#4993 Cc @folkertdev since it also changes the checks for variadics.
…enyukang Validate source snippet when format input is raw string Fixes rust-lang#114865 The issue occurred because the user's proc macro respanned the format arg to an unrelated multi-byte string and we ICE'd by landing in the middle of a multi-byte char. This PR adds validation that prevents the parser from trying to walk such obviously wrong snippets. Such validation already existed for non-raw strings. This PR adds it for raw strings as well.
Remove unused spans from AttributeKind Recently I noticed some spans in diagnostic attributes were never used. I went through and checked the other variants too.
Move and rename the `clone-never.rs` test
change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools` Makes tools actually stored, and not just tool names this was originally part of rust-lang#155691 but was split out to make that PR smaller. r? @petrochenkov cc @JonathanBrouwer
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
☔ The latest upstream changes (presumably #154341) made this pull request unmergeable. Please resolve the merge conflicts. This pull request was unapproved. |
rust-bors
Bot
removed
the
S-waiting-on-bors
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
clone-never.rstest #156079 (Move and rename theclone-never.rstest)toolsonAttributeParserto hold&'tcx RegisteredTools#156091 (change fieldtoolsonAttributeParserto hold&'tcx RegisteredTools)r? @ghost
Create a similar rollup