Skip to content

Return NODE_NAME_NON_EXISTENT instead of ERROR. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eboasson merged 1 commit into from
Sep 24, 2019
Merged

Return NODE_NAME_NON_EXISTENT instead of ERROR. #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions rmw_cyclonedds_cpp/src/rmw_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2442,9 +2442,9 @@ static rmw_ret_t get_node_guids(
if (ret != RMW_RET_OK) {
return ret;
} else if (guids.size() == 0) {
/* It appears the get_..._by_node operations are supposed to return ERROR if no such node
exists */
return RMW_RET_ERROR;
/* It appears the get_..._by_node operations are supposed to return NODE_NAME_NON_EXISTENT
if no such node exists */
return RMW_RET_NODE_NAME_NON_EXISTENT;
} else {
return RMW_RET_OK;
}
Expand Down