forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 4
[RUN-3009] Keep track of ReplayScriptAlive and error-out executeCommand calls if its not
#1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Domiii
merged 16 commits into
master
from
dominik/run-3009-error-no-context-group-available-for-isolate
Jan 11, 2024
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e5b75e7
[RUN-3009] Keep track of `gAlive` and error-out `executeCommand` call…
Domiii a192d6b
DEPS (v8)
Domiii 705e165
Merge branch 'master' of github.com:replayio/chromium into dominik/ru…
Domiii 1315e01
Hook up `RecordReplayHandleScriptShutdown` and friends
Domiii 13cb4ce
Remove `V8RecordReplayGetContextId` for now
Domiii f572af8
DEPS (v8)
Domiii 7fc43d2
2a74949
Fix initialization logic to support cross-domain navigation + cleanup
Domiii adfd95e
rename vars
Domiii 417048e
Remove "single root frame" assumption
Domiii e38aab6
Assume a single local root frame per render process
Domiii 97e14e5
names, comments, clean up
Domiii 7173c87
Merge branch 'master' of github.com:replayio/chromium into dominik/ru…
Domiii 9fbcd49
Merge branch 'master' of github.com:replayio/chromium into dominik/ru…
Domiii b2ca5a8
small fixes
Domiii 5996f74
lint + comment
Domiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This did not handle potential cross-domain (and maybe other types of?) navigation where the frame does not get re-used.