Conversation
…n-3009-error-no-context-group-available-for-isolate
Domiii
changed the title
gAlive and error-out executeCommand calls if its notReplayScriptAlive and error-out executeCommand calls if its not
Author
|
|
Domiii
commented
Jan 9, 2024
| InitializeRecordReplay(GetIsolate(), GetFrame(), context); | ||
| } | ||
|
|
||
| if (doInit || GetFrame() == gRecordReplayFrame) { |
Author
There was a problem hiding this comment.
Note: This did not handle potential cross-domain (and maybe other types of?) navigation where the frame does not get re-used.
toshok
approved these changes
Jan 10, 2024
Comment on lines
239
to
241
| // Some of these are duplicated in gSourceMapScript, so watch out when making | ||
| // modifications to update both versions... | ||
|
|
There was a problem hiding this comment.
these comments (and including utils.js above) are making less sense now. should we move other things up above (like assert, isFunction, isObject, typeofMaybeNull)? or remove the utils.js comment?
| // about to reset, and its ExecutionContext and our V8 debugger session with it. | ||
| // From this point forward, command handling is not possible anymore | ||
| // until a new page is spawned. | ||
| // Note: JS can still execute, even after this happened. |
|
|
||
| // NOTE: The root `LocalFrame` will actually not change over time. | ||
| gLocalRootFrame = localFrame; | ||
| // NOTE: The root `LocalFrame` will not necessarily change over time. |
There was a problem hiding this comment.
I think this isn't a strong enough assertion. how about:
Suggested change
| // NOTE: The root `LocalFrame` will not necessarily change over time. | |
| // NOTE: The root `LocalFrame` can change over time. |
…n-3009-error-no-context-group-available-for-isolate
Author
Its rather different:
|
…n-3009-error-no-context-group-available-for-isolate
Domiii
deleted the
dominik/run-3009-error-no-context-group-available-for-isolate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm test -- replay-api/basics/run-2965.spec.ts(which opens a page and then navigates twice)STATUS_CHANGE_ALIVE+ 2 xSTATUS_CHANGE_UNALIVE