-
Notifications
You must be signed in to change notification settings - Fork 0
Sharing Sessions #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cb341
wants to merge
10
commits into
main
Choose a base branch
from
feature/support-query-parameters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Sharing Sessions #208
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e7db522
Initial implementation
cb341 5077d68
Update container, refactor
cb341 0560339
Refactor
cb341 127d829
Update prefil notice
cb341 79f05f5
Mention seeding in README.md
cb341 8bb0a08
Update seeding
cb341 a8e4cb3
Rename Message value
cb341 53c7df0
Refactor sessions, add share button to past sessions
cb341 633f563
Refactorings
cb341 6474170
"Fix" flakey test
cb341 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
assets.src/src/redmine-tracky/controllers/share-link-controller.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| import { Controller } from '@hotwired/stimulus' | ||
|
|
||
| export default class extends Controller<HTMLAnchorElement> { | ||
| declare readonly copiedMessageValue: string | ||
|
|
||
| static values = { | ||
| copiedMessage: String, | ||
| } | ||
|
|
||
| public copy(event: Event) { | ||
| event.preventDefault() | ||
| const href = this.element.href | ||
| const url = new URL(href, window.location.origin).toString() | ||
|
|
||
| navigator.clipboard.writeText(url).then(() => { | ||
| this.showFlash(this.copiedMessageValue) | ||
| }) | ||
| } | ||
|
|
||
| private showFlash(message: string) { | ||
| const flashId = 'flash_notice' | ||
| const existing = document.getElementById(flashId) | ||
| if (existing) { | ||
| existing.textContent = message | ||
| existing.style.display = '' | ||
| return | ||
| } | ||
|
|
||
| const container = document.getElementById('content') | ||
| if (!container) return | ||
|
|
||
| const flash = document.createElement('div') | ||
| flash.id = flashId | ||
| flash.className = 'flash notice' | ||
| flash.textContent = message | ||
| container.prepend(flash) | ||
|
Comment on lines
+32
to
+36
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the downside of having the prefill logic in the frontend. Luckily it is not that much code. |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.