Conversation
cb341
commented
Mar 8, 2026
cb341
commented
Mar 8, 2026
cb341
commented
Mar 8, 2026
cb341
commented
Apr 22, 2026
cb341
commented
Apr 22, 2026
cb341
commented
Apr 22, 2026
| }, 0) | ||
| } | ||
|
|
||
| private prefillField(urlParams: URLSearchParams, param: string, target: HTMLInputElement): boolean { |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| private prefillField(urlParams: URLSearchParams, param: string, target: HTMLInputElement): boolean { | |
| private isPrefillField(urlParams: URLSearchParams, param: string, target: HTMLInputElement): boolean { |
Contributor
Author
There was a problem hiding this comment.
Or
Suggested change
| private prefillField(urlParams: URLSearchParams, param: string, target: HTMLInputElement): boolean { | |
| private shouldPrefillField(urlParams: URLSearchParams, param: string, target: HTMLInputElement): boolean { |
cb341
commented
Apr 22, 2026
Comment on lines
+32
to
+36
| const flash = document.createElement('div') | ||
| flash.id = flashId | ||
| flash.className = 'flash notice' | ||
| flash.textContent = message | ||
| container.prepend(flash) |
Contributor
Author
There was a problem hiding this comment.
This is the downside of having the prefill logic in the frontend.
We need to duplicate logic for rendering flashes.
Luckily it is not that much code.
cb341
force-pushed
the
feature/support-query-parameters
branch
from
4c870fa to
53c7df0
Compare
cb341
force-pushed
the
feature/support-query-parameters
branch
from
b4cb708 to
633f563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session Sharing
I think this could be a useful feature for meetings / pair programmings and spontanous code reviews.
One person defines a session and shares it with members, ensuring consistent tracking of sessions.
Implementation done by Opus 4.6
It is also possible to copy a past session:
