Skip to content

ct/frontend: co_await in do_load_slice #30176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvartolomei wants to merge 1 commit into
base: dev
Choose a base branch
from
+5 −12
Open

ct/frontend: co_await in do_load_slice #30176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/v/cloud_topics/level_one/frontend_reader/level_one_reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,10 @@ ss::future<model::record_batch_reader::storage_t>
level_one_log_reader_impl::do_load_slice(
model::timeout_clock::time_point deadline) {
try {
return read_some(deadline);
co_return co_await read_some(deadline);
} catch (...) {
vlog(
_log.error, "Reader caught exception: {}", std::current_exception());
_log.debug, "Reader caught exception: {}", std::current_exception());
Copy link
Copy Markdown
Contributor

@WillemKauf WillemKauf Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not warn if not a shutdown exception?

set_end_of_stream();
throw;
}
Expand Down
1 change: 0 additions & 1 deletion src/v/cloud_topics/level_zero/frontend_reader/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ redpanda_cc_library(
"//src/v/cloud_topics/level_zero/stm:placeholder",
"//src/v/cluster",
"//src/v/config",
"//src/v/ssx:future_util",
],
visibility = ["//visibility:public"],
deps = [
Expand Down
12 changes: 3 additions & 9 deletions src/v/cloud_topics/level_zero/frontend_reader/level_zero_reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
#include "cluster/partition.h"
#include "config/configuration.h"
#include "model/timeout_clock.h"
#include "ssx/future-util.h"

#include <seastar/coroutine/maybe_yield.hh>

Expand Down Expand Up @@ -50,15 +49,10 @@ ss::future<model::record_batch_reader::storage_t>
level_zero_log_reader_impl::do_load_slice(
model::timeout_clock::time_point deadline) {
try {
return read_some(deadline);
co_return co_await read_some(deadline);
} catch (...) {
auto ex = std::current_exception();
vlogl(
_log,
ssx::is_shutdown_exception(ex) ? ss::log_level::debug
: ss::log_level::error,
"Reader caught exception: {}",
ex);
vlog(
_log.debug, "Reader caught exception: {}", std::current_exception());
set_end_of_stream();
throw;
}
Expand Down
Loading