ct/frontend: co_await in do_load_slice#30176
Open
nvartolomei wants to merge 1 commit intodevfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates cloud topics frontend log readers so that exceptions originating from read_some() are caught by the local try/catch in do_load_slice(), by converting the call path to use C++ coroutines (co_await/co_return).
Changes:
- Update
level_zero_log_reader_impl::do_load_slice()toco_awaittheread_some()future so exceptions are handled by the surroundingtry/catch. - Update
level_one_log_reader_impl::do_load_slice()similarly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/v/cloud_topics/level_zero/frontend_reader/level_zero_reader.cc | Switch do_load_slice() to co_return co_await read_some(...) so read_some exceptions are caught/logged before rethrow. |
| src/v/cloud_topics/level_one/frontend_reader/level_one_reader.cc | Same coroutine conversion in do_load_slice() to ensure exception handling works as intended. |
wdberkeley
previously approved these changes
Apr 15, 2026
Collaborator
Retry command for Build#83191please wait until all jobs are finished before running the slash command |
Collaborator
nvartolomei
force-pushed
the
nv/ct-fix-do-load-slice-coroutine
branch
from
48f7166 to
3cbd0d6
Compare
Collaborator
Retry command for Build#83203please wait until all jobs are finished before running the slash command |
Use co_return/co_await instead of plain return so that exceptions from read_some are caught by the surrounding try/catch block. Log at debug level since exceptions here are not necessarily software errors — the caller may have triggered an abort source.
nvartolomei
force-pushed
the
nv/ct-fix-do-load-slice-coroutine
branch
from
3cbd0d6 to
a6265a5
Compare
WillemKauf
reviewed
Apr 17, 2026
| } catch (...) { | ||
| vlog( | ||
| _log.error, "Reader caught exception: {}", std::current_exception()); | ||
| _log.debug, "Reader caught exception: {}", std::current_exception()); |
Contributor
There was a problem hiding this comment.
why not warn if not a shutdown exception?
dotnwat
reviewed
Apr 20, 2026
Member
dotnwat
left a comment
dotnwat
left a comment
There was a problem hiding this comment.
nice catch! pr lgtm but the changes to the log level handling shutdown scenarios isn't explained afaict.
Contributor
|
@nvartolomei should we get this merged (after addressing the logging?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use co_return/co_await instead of plain return so that exceptions from read_some are caught by the surrounding try/catch block.
Backports Required
Release Notes