Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,13 @@ use_repo(
bazel_dep(name = "gazelle", version = "0.45.0")
bazel_dep(name = "abseil-cpp", version = "20250814.0")
bazel_dep(name = "bazel_skylib", version = "1.8.1")
bazel_dep(name = "c-ares", version = "1.34.5.bcr.3")
bazel_dep(name = "crc32c", version = "1.1.0")
bazel_dep(name = "fmt", version = "9.1.0")
bazel_dep(name = "googletest", version = "1.17.0")
bazel_dep(name = "lexy", version = "2025.05.0")
bazel_dep(name = "liburing", version = "2.5")
bazel_dep(name = "libxml2", version = "2.15.1")
bazel_dep(name = "lz4", version = "1.9.4")
bazel_dep(name = "platforms", version = "1.0.0")
bazel_dep(name = "protobuf", version = "31.1")
Expand Down Expand Up @@ -82,14 +84,12 @@ non_module_dependencies = use_extension("//bazel:extensions.bzl", "non_module_de
use_repo(non_module_dependencies, "ada")
use_repo(non_module_dependencies, "avro")
use_repo(non_module_dependencies, "base64")
use_repo(non_module_dependencies, "c-ares")
use_repo(non_module_dependencies, "hdrhistogram")
use_repo(non_module_dependencies, "hwloc")
use_repo(non_module_dependencies, "jsoncons")
use_repo(non_module_dependencies, "krb5")
use_repo(non_module_dependencies, "libpciaccess")
use_repo(non_module_dependencies, "libprotobuf_mutator")
use_repo(non_module_dependencies, "libxml2")
use_repo(non_module_dependencies, "lksctp")
use_repo(non_module_dependencies, "openssl")
use_repo(non_module_dependencies, "openssl-fips")
Expand Down
42 changes: 20 additions & 22 deletions MODULE.bazel.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 0 additions & 16 deletions bazel/repositories.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,6 @@ def data_dependency():
url = "https://vectorized-public.s3.amazonaws.com/dependencies/base64-v0.5.0.tar.gz",
)

http_archive(
name = "c-ares",
build_file = "//bazel/thirdparty:c-ares.BUILD",
sha256 = "7d935790e9af081c25c495fd13c2cfcda4792983418e96358ef6e7320ee06346",
strip_prefix = "c-ares-1.34.5",
url = "https://vectorized-public.s3.amazonaws.com/dependencies/c-ares-1.34.5.tar.gz",
)

http_archive(
name = "hdrhistogram",
build_file = "//bazel/thirdparty:hdrhistogram.BUILD",
Expand Down Expand Up @@ -97,14 +89,6 @@ def data_dependency():
url = "https://github.com/google/libprotobuf-mutator/archive/dc4ced337a9fb4047e2dc727268fbac55ca82f73.zip",
)

http_archive(
name = "libxml2",
build_file = "//bazel/thirdparty:libxml2.BUILD",
sha256 = "f52638e4d67135c49f676d1c8fcc4f9f35afb7ec9bfb4aee743e2e86d56e006b",
strip_prefix = "libxml2-2.14.5",
url = "https://vectorized-public.s3.us-west-2.amazonaws.com/dependencies/libxml2-v2.14.5.tar.gz",
)

http_archive(
name = "lksctp",
build_file = "//bazel/thirdparty:lksctp.BUILD",
Expand Down
24 changes: 0 additions & 24 deletions bazel/thirdparty/c-ares.BUILD

This file was deleted.

30 changes: 0 additions & 30 deletions bazel/thirdparty/libxml2.BUILD

This file was deleted.

2 changes: 1 addition & 1 deletion bazel/thirdparty/seastar.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ cc_library(
"@boost//:lockfree",
"@boost//:program_options",
"@boost//:thread",
"@c-ares",
"@c-ares//:ares",
"@fmt",
"@lksctp",
"@lz4",
Expand Down
2 changes: 1 addition & 1 deletion src/v/cloud_storage_clients/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ redpanda_cc_library(
"//src/v/ssx:sformat",
"//src/v/ssx:watchdog",
"//src/v/strings:string_switch",
"//src/v/thirdparty/libxml2",
"//src/v/utils:base64",
"//src/v/utils:log_hist",
"//src/v/utils:named_type",
Expand All @@ -65,6 +64,7 @@ redpanda_cc_library(
"@boost//:beast",
"@boost//:lexical_cast",
"@boost//:property_tree",
"@libxml2",
"@seastar",
],
)
3 changes: 2 additions & 1 deletion src/v/cloud_storage_clients/xml_sax_parser.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
#pragma once

#include "cloud_storage_clients/client.h"
#include "thirdparty/libxml2/parser.h"

#include <seastar/core/iostream.hh>

#include <libxml/parser.h>

namespace cloud_storage_clients {

class xml_parse_exception : public std::exception {
Expand Down
4 changes: 2 additions & 2 deletions src/v/kafka/client/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,14 @@ redpanda_cc_library(
"//src/v/random:generators",
"//src/v/security",
"//src/v/ssx:future_util",
"//src/v/thirdparty/c-ares",
"//src/v/utils:backoff_policy",
"//src/v/utils:mutex",
"//src/v/utils:prefix_logger",
"//src/v/utils:unresolved_address",
"//src/v/version",
"@abseil-cpp//absl/container:flat_hash_map",
"@abseil-cpp//absl/container:flat_hash_set",
"@c-ares//:ares",
"@fmt",
"@seastar",
],
Expand Down Expand Up @@ -359,7 +359,6 @@ redpanda_cc_library(
"//src/v/ssx:semaphore",
"//src/v/storage:record_batch_builder",
"//src/v/strings:string_switch",
"//src/v/thirdparty/c-ares",
"//src/v/utils:mutex",
"//src/v/utils:prefix_logger",
"//src/v/utils:retry",
Expand All @@ -369,6 +368,7 @@ redpanda_cc_library(
"@abseil-cpp//absl/container:flat_hash_set",
"@abseil-cpp//absl/container:node_hash_map",
"@abseil-cpp//absl/hash",
"@c-ares//:ares",
"@fmt",
"@seastar",
],
Expand Down
3 changes: 2 additions & 1 deletion src/v/kafka/client/broker.cc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "security/oidc_authenticator.h"
#include "security/plain_authenticator.h"
#include "security/scram_authenticator.h"
#include "thirdparty/c-ares/ares.h"
#include "utils/backoff_policy.h"
#include "utils/unresolved_address.h"
#include "version/version.h"
Expand All @@ -26,6 +25,8 @@
#include <seastar/core/sleep.hh>
#include <seastar/coroutine/as_future.hh>
#include <seastar/net/dns.hh>

#include <ares.h>
using namespace std::chrono_literals;
namespace {
bool is_dns_failure_error(const std::system_error& e) {
Expand Down
2 changes: 1 addition & 1 deletion src/v/test_utils/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ redpanda_test_cc_library(
"boost_result_redirect.cc",
],
implementation_deps = [
"//src/v/thirdparty/libxml2",
"@abseil-cpp//absl/strings",
"@abseil-cpp//absl/strings:str_format",
"@abseil-cpp//absl/time",
"@boost//:config",
"@boost//:core",
"@boost//:test",
"@libxml2",
],
visibility = ["//visibility:public"],
)
Expand Down
2 changes: 1 addition & 1 deletion src/v/test_utils/boost_result_redirect.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
#include "absl/strings/str_format.h"
#include "absl/strings/str_replace.h"
#include "absl/time/time.h"
#include "thirdparty/libxml2/xmlwriter.h"

#include <boost/test/results_collector.hpp>
#include <boost/test/tree/traverse.hpp>
#include <boost/test/unit_test.hpp>
#include <boost/test/unit_test_suite.hpp>
#include <libxml/xmlwriter.h>

#include <stdexcept>

Expand Down
13 changes: 0 additions & 13 deletions src/v/thirdparty/c-ares/BUILD

This file was deleted.

3 changes: 0 additions & 3 deletions src/v/thirdparty/c-ares/ares.h

This file was deleted.

14 changes: 0 additions & 14 deletions src/v/thirdparty/libxml2/BUILD

This file was deleted.

3 changes: 0 additions & 3 deletions src/v/thirdparty/libxml2/parser.h

This file was deleted.

3 changes: 0 additions & 3 deletions src/v/thirdparty/libxml2/xmlwriter.h

This file was deleted.

2 changes: 1 addition & 1 deletion tests/rptest/tests/cluster_features_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ def test_old_node_join(self):
pass
else:
raise RuntimeError(
f"Node {old_node} joined cluster, but should have been rejected"
f"Node {old_node.name} joined cluster, but should have been rejected"
)

# Restart it with a sufficiently recent version and join should succeed
Expand Down