Skip to content

Builds: Add get_result_display property to Build model #13105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericholscher wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −0
Open

Builds: Add get_result_display property to Build model #13105

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1204c4
Builds: Add get_result_display property to Build model
claude Jun 4, 2026
06858a0
Change get_result_display from property to method
claude Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions readthedocs/builds/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from readthedocs.builds.constants import BRANCH
from readthedocs.builds.constants import BUILD_FINAL_STATES
from readthedocs.builds.constants import BUILD_STATE
from readthedocs.builds.constants import BUILD_STATE_CANCELLED
from readthedocs.builds.constants import BUILD_STATE_FINISHED
from readthedocs.builds.constants import BUILD_STATE_TRIGGERED
from readthedocs.builds.constants import BUILD_STATUS_CHOICES
Expand Down Expand Up @@ -1064,6 +1065,17 @@ def get_commit_url(self):

return None

@property
def get_result_display(self):
Comment thread
ericholscher marked this conversation as resolved.
Outdated
"""Human-readable build result combining state and success."""
if self.state == BUILD_STATE_FINISHED:
if self.success:
return _("Build passed")
return _("Build failed")
if self.state == BUILD_STATE_CANCELLED:
return _("Build cancelled")
return _("Building")

@property
def finished(self):
"""Return if build has an end state."""
Expand Down