Builds: Add get_result_display property to Build model#13105
Open
ericholscher wants to merge 2 commits into
Open
Builds: Add get_result_display property to Build model#13105ericholscher wants to merge 2 commits into
ericholscher wants to merge 2 commits into
Conversation
Centralizes the human-readable build result logic (passed/failed/ cancelled/building) so templates and other code can reuse it. https://claude.ai/code/session_012fjaaMr8qJHLJsqmJqE78e
Contributor
There was a problem hiding this comment.
Pull request overview
This PR centralizes “human-readable build result” formatting on the Build model, so templates/clients can rely on a single source of truth (notably for build detail OpenGraph metadata).
Changes:
- Add
Build.get_result_displayto return a user-facing string for build outcomes (passed/failed/cancelled/in-progress). - Import
BUILD_STATE_CANCELLEDto support cancelled-state handling in the new display logic.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Consistent with Django's get_<field>_display() convention. https://claude.ai/code/session_012fjaaMr8qJHLJsqmJqE78e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
get_result_displayproperty to the Build model that returns a human-readable build result string: "Build passed", "Build failed", "Build cancelled", or "Building". This centralizes logic that was previously duplicated in templates and JavaScript.Companion to ext-theme#758, which uses this property for OpenGraph meta tags on build detail pages.
Generated by Claude Code
Generated by Claude Code