Optimize link checkCollision not to synchronize unnecessary links - #1511
Conversation
…o improveLinkCheckCollision20250430
…o improveLinkCheckCollision20250430
…o improveLinkCheckCollision20250430
…ed inside _SynchronizeLink
|
@cielavenir please check for regressions here, this is touching on some of the most critical and low level code we have. thanks |
|
autotester: https://tiny.mujin.co.jp/t79gx |
|
that autotester was flaky but our testing in latest_test.json is going well so far cc @ntohge |
|
Looks good to me. @rdiankov |
|
@rdiankov btw, can you please add Yuta (https://github.com/YutaKojio) to openrave member so that he can create a PR from here (this PR is from his fork). |
…o improveLinkCheckCollision20250430
|
The change looks good to me. @YutaKojio However, this PR can just be a patch version increment since no ABI change. |
|
@yoshikikanemoto Thank you. Updated the version and changelog to be a patch increment. |
|
@YutaKojio can you resolve a conflict? |
…o improveLinkCheckCollision20250430
|
@yoshikikanemoto Resolved the version conflict. |
|
Hm I saw this but it should not be related to this MR.... |
|
I think it's not related to this PR, but I'm not sure the cause. |
|
for now leave the CI matter to #1515 |
|
@kanbouchou could you check again just in case? |
|
This branch is repeatedly tested in latest_test pipeline, so it should be ok. |
|
Thanks! |
This PR is to speed up a collision check for links especially when the robot has many links.
Currently,
Synchronizeis called againt all links whenever_nUpdateStampIdin the body is updated, which is incremented every time any link state changes.However, when checking collision for a certain link, there is no need to synchronize other links.
This PR introduces
FCLSpace::SynchronizeLinkto synchronize only the link of interest.The cases that this PR improves:
and
for example.