Skip to content

Don't write find_package redirects for DOWNLOAD_ONLY packages - #1114

Draft
bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:fix-download-only-redirect
Draft

bdice wants to merge 1 commit into
rapidsai:mainfrom
bdice:fix-download-only-redirect

Conversation

@bdice

@bdice bdice commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Description

#1089 made rapids_cpm_find translate DOWNLOAD_ONLY into a placeholder SOURCE_SUBDIR. CPM ties redirect suppression to DOWNLOAD_ONLY, so download-only packages started getting an empty find_package redirect stub that shadows every later find_package(<name>) in the build. This sets CPM_DONT_UPDATE_MODULE_PATH alongside the translation, which restores the pre-#1089 behavior. The setting is scoped to the rapids_cpm_find call, the same approach rapids_cpm_cccl takes (#997).

Closes #1113
xref NVIDIA/cudf#25124

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@bdice bdice added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] rapids_cpm_find(... DOWNLOAD_ONLY ON) writes an empty find_package redirect

1 participant