Feature/xdai - #1464
Closed
hexyls wants to merge 63 commits into
Closed
Conversation
hexyls
marked this pull request as draft
December 17, 2020 04:06
hexyls
marked this pull request as ready for review
December 22, 2020 03:44
hexyls
marked this pull request as draft
December 22, 2020 04:01
Mi-Lan
approved these changes
Jan 5, 2021
Mi-Lan
left a comment
Mi-Lan
left a comment
Contributor
There was a problem hiding this comment.
Good job hexyls! Works flawlessly i tested these features:
- Market Creation
- Depositing liquidity
- Withdrawing liquidity
- Buy action
- Sell action
Here is the market i created and tested it on http://localhost:3000/#/0x3fd8ead8df4f8700027a1e3c39dd74e3f430176e
Contributor
|
replaced by #1262 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1409
PR does not include verification, we can add that later once the kleros/curate subgraph is up for xDai.
Name: xDai
RPC: https://rpc.xdaichain.com/
Chain ID: 100
Symbol: xDai
Block explorer: https://blockscout.com/poa/xdai