Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 - #1466
Compound integration with Omen Markets. Archived in favor of https://github.com/protofire/omen-exchange/pull/1570 #1466pRoy24 wants to merge 59 commits into
Conversation
pRoy24
changed the title
pRoy24
changed the title
|
just played around with it on Rinkeby and I am getting an error after clicking on circle button to enable it: Steps to reproduce:
|
You need to run Yarn install since it uses Big.js version 6.0.0 for the prec function |
|
Hey @pRoy24 , once I enable compound the pool number is jumping around: |
|
Every market info component here has a svg in 24x24. The compound svg you included is 16x16: please use this svg: |
|
Please remove the styling if the circle button is active, currently if you hover over it you see the border is popping up: |
|
If you hover over the compound info the icon is turning blue, which is not according my design specification. Currently: Should: onHover color: #00897B |
|
Just looking at the price of the outcomes here: I believe those prices are in cDAI and not in DAI right? Are we able to calculate all of this to DAI? |
|
Looks like after I done a swap, the form is not resetting which is our default. Doing a swap: after the swap is done, the inputfield is still filled with the number 2 and I see order details: It should reset the order form as we do on default. |
it looks like now the the border got removed when holding on-click: |
|
The compound icon is still not correct, currently: should: did you actually replaced the svg which I provided? |
you changed the normal color to #00897B, but you actually should use #00897B as the hover color for the icon and the text. |
…as to transforming tokens as opposed to transforming prices
| const ServiceTextWrapper = styled.div` | ||
| width: 90%; | ||
| ` | ||
|
|
||
| const ServiceCheckWrapper = styled.div` | ||
| width: 10%; | ||
| color: transparent; |
There was a problem hiding this comment.
I dont think defining static values to width here is neccesary. I would suggest just adding
justify-content: space-between; to the parent element that is 100% and omitting width for these two values. The reason for this is because 10% is slightly more than 40px and creates this unnecessary margin...
| cdai: { | ||
| symbol: 'cDAI', | ||
| decimals: 18, |
There was a problem hiding this comment.
Would be good to have consistent letter formatting for both currencies. To make them both capital or with first letter Uppercase (which is according to design...
There was a problem hiding this comment.
Yup, makes sense refactored to include the change.
pRoy24
changed the title
pRoy24
changed the title
5 participants
Fixed the previous round of comments.
Added badge as defined in the mockup.
Refactored to make it work with ETH as the base and cETH as the underlying collateral.
Tested on Rinkeby with ETH -> cETH and dai -> cDAI pairs.
Please note that you need to run yarn install since this feature uses Big.js version 6.0.0