Cleanup: sort globalVariables alphabetically in R/zzz.R - #1413
Open
tieganhulbert wants to merge 3 commits into
Open
Cleanup: sort globalVariables alphabetically in R/zzz.R #1413tieganhulbert wants to merge 3 commits into
tieganhulbert wants to merge 3 commits into
Conversation
3 tasks
Gero1999
reviewed
Jul 27, 2026
Comment on lines
+199
to
+3
| )) | ||
| ".", |
Collaborator
There was a problem hiding this comment.
hello @tieganhulbert! I can see this was accidentally re-identedd identation was addedd by accident. You can do shift+tab to solve it
Gero1999
reviewed
Jul 27, 2026
Comment on lines
+165
to
+166
| "se", | ||
| "SE", |
Collaborator
There was a problem hiding this comment.
uppercase before lowercase
Suggested change
| "se", | |
| "SE", | |
| "SE", | |
| "se", |
Gero1999
reviewed
Jul 27, 2026
Comment on lines
+185
to
+187
| "type", | ||
| "Type", | ||
| "TYPE", |
Collaborator
There was a problem hiding this comment.
uppercase before lowercase
Suggested change
| "type", | |
| "Type", | |
| "TYPE", | |
| "TYPE", | |
| "Type", | |
| "type", |
Gero1999
requested changes
Jul 27, 2026
Collaborator
Author
|
Issues found in review fixed. Can others review again please @Gero1999 @Shaakon35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #1369
Description
R/zzz.R contains 193 globalVariables entries that are not alphabetically sorted. AGENTS.md requires them to be kept sorted.
Definition of Done
How to test
Open R/zzz.R and verify the list of variables are alphabetical.
Contributor checklist
.scsschange was done, rundata-raw/compile_css.Rdata-raw/test_suggests_hidden.RNotes to reviewer
Anything that the reviewer should know before tacking the pull request?