OSAC-3879: honor E2E path-ignore on merge queue - #242
Conversation
Merge queue previously always ran full E2E because should-run short-circuited for non-pull_request events. Filter both PR and merge_group; keep schedule/dispatch always-on and gate jobs. Assisted-by: Cursor <noreply@cursor.com>
|
@minmzzhang: This pull request references OSAC-3879 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe three E2E workflows now support ChangesE2E merge-group workflow support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/e2e-bmaas-full-install.yml:
- Line 50: Update the should-run conditions at
.github/workflows/e2e-bmaas-full-install.yml:50,
.github/workflows/e2e-caas-full-install.yml:50, and
.github/workflows/e2e-vmaas-full-install.yml:50 to fail closed for merge_group
events unless explicit authorization data is available, preventing reusable
workflows from fetching E2E secrets; preserve the existing behavior for
non-merge-group events and authorized pull requests.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 37810e5b-3cab-4e66-a0f5-4a83e78f5ecc
📒 Files selected for processing (3)
.github/workflows/e2e-bmaas-full-install.yml.github/workflows/e2e-caas-full-install.yml.github/workflows/e2e-vmaas-full-install.yml
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eliorerz, minmzzhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Auto-dismissed: only Prow labels gate merging
Summary
merge_groupas onpull_request, so merge-queue entries no longer always run full bmaas+caas+vmaas E2Eschedule/workflow_dispatchalways-on; keepe2e-*-gatewithif: always()so required ruleset checks still report when E2E is skippedfetch-depth: 0andpersist-credentials: falsefor merge_group (dorny/paths-filter uses git diff)Jira
https://redhat.atlassian.net/browse/OSAC-3879
Test plan
schedule/workflow_dispatch: E2E still always runsSummary by CodeRabbit