Skip to content

OSAC-3830: Skip CI for non-code changes: AI agent config, design, tooling - #214

Merged
omer-vishlitzky merged 1 commit into
osac-project:mainfrom
rgolangh:skip-ci-for-non-code-changes
Aug 11, 2026
Merged

OSAC-3830: Skip CI for non-code changes: AI agent config, design, tooling#214
omer-vishlitzky merged 1 commit into
osac-project:mainfrom
rgolangh:skip-ci-for-non-code-changes

Conversation

@rgolangh

@rgolangh rgolangh commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Extend the dorny/paths-filter exclusion list in all 6 workflows that use it (3 e2e, unit-tests, integration-tests, check-generated-code)
  • New exclusions: .claude/, .cursor/, .gemini/ (AI agent config), .design/ (design context), .skillsaw.yaml, .pre-commit-config.yaml
  • The existing exclusions (*.md, OWNERS, LICENSE, docs/) already cover documentation-only PRs — these additions cover AI agent configuration and development tooling that don't affect runtime behavior

Context

PR #213 (docs-only: adding AGENTS.md for osac-csi-driver) triggered all e2e workflow runs. The changes job correctly skipped the actual test jobs via the !**/*.md filter, but non-md files in .claude/ directories (settings.json, hooks) would not have been caught.

Test plan

  • Verify dorny/paths-filter syntax is correct (negation patterns follow .gitignore semantics)
  • Confirm existing code-change PRs still trigger tests (positive patterns unchanged)
  • This PR itself should demonstrate the skip behavior (workflow-only changes)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated automated workflow triggers to ignore changes limited to development-tooling, design, and assistant configuration files.
    • Prevents unnecessary unit, integration, end-to-end, and generated-code checks when application code is unaffected.
    • Keeps validation focused on changes that can impact product behavior, improving development feedback efficiency.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: da89038d-ddce-445c-b79f-559df206a369

📥 Commits

Reviewing files that changed from the base of the PR and between 94b6626 and 91327a8.

📒 Files selected for processing (6)
  • .github/workflows/check-generated-code.yaml
  • .github/workflows/e2e-bmaas-full-install.yml
  • .github/workflows/e2e-caas-full-install.yml
  • .github/workflows/e2e-vmaas-full-install.yml
  • .github/workflows/integration-tests.yml
  • .github/workflows/unit-tests.yml

Walkthrough

The pull-request filters for installation, integration-test, unit-test, and generated-code workflows now exclude assistant-related directories, design files, and selected configuration files.

Changes

CI path filter exclusions

Layer / File(s) Summary
Workflow trigger exclusions
.github/workflows/e2e-bmaas-full-install.yml, .github/workflows/e2e-caas-full-install.yml, .github/workflows/e2e-vmaas-full-install.yml, .github/workflows/integration-tests.yml, .github/workflows/unit-tests.yml
Pull-request filters now exclude .claude, .cursor, .gemini, .design, .skillsaw.yaml, and .pre-commit-config.yaml where applicable.
Generated-code component exclusions
.github/workflows/check-generated-code.yaml
Pull-request and component filters now exclude .claude changes.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: ok-to-test

Suggested reviewers: avishayt, zszabo-rh, eliorerz

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: skipping CI for AI-agent configuration, design, and tooling changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The PR adds only 34 workflow path exclusions; scans found no secret identifiers, credential URLs, private-key material, or recognized API-key/base64/hex secret shapes.
No-Weak-Crypto ✅ Passed The PR adds only 34 YAML path-filter lines across six workflows; added-content scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or timing-unsafe comparisons.
No-Injection-Vectors ✅ Passed The PR adds only 34 quoted static path-filter globs; no SQL, shell, eval/exec, pickle, unsafe YAML, os.system, or HTML injection constructs were added.
Container-Privileges ✅ Passed The PR adds only path-filter entries in six GitHub workflow files; no added line contains privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The patch adds only negated path-filter entries. It adds no logging commands, secret values, or sensitive-data output.
Ai-Attribution ✅ Passed AI use is disclosed in the PR and the sole PR commit has an Assisted-by: Claude Code trailer; no AI Co-Authored-By trailer is present.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rgolangh rgolangh changed the title Skip CI for non-code changes: AI agent config, design, tooling NO-ISSUE: Skip CI for non-code changes: AI agent config, design, tooling Aug 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@rgolangh: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Extend the dorny/paths-filter exclusion list in all 6 workflows that use it (3 e2e, unit-tests, integration-tests, check-generated-code)
  • New exclusions: .claude/, .cursor/, .gemini/ (AI agent config), .design/ (design context), .skillsaw.yaml, .pre-commit-config.yaml
  • The existing exclusions (*.md, OWNERS, LICENSE, docs/) already cover documentation-only PRs — these additions cover AI agent configuration and development tooling that don't affect runtime behavior

Context

PR #213 (docs-only: adding AGENTS.md for osac-csi-driver) triggered all e2e workflow runs. The changes job correctly skipped the actual test jobs via the !**/*.md filter, but non-md files in .claude/ directories (settings.json, hooks) would not have been caught.

Test plan

  • Verify dorny/paths-filter syntax is correct (negation patterns follow .gitignore semantics)
  • Confirm existing code-change PRs still trigger tests (positive patterns unchanged)
  • This PR itself should demonstrate the skip behavior (workflow-only changes)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@eranco74 eranco74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eranco74, rgolangh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rgolangh rgolangh changed the title NO-ISSUE: Skip CI for non-code changes: AI agent config, design, tooling OSAC-3830: Skip CI for non-code changes: AI agent config, design, tooling Aug 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 9, 2026

Copy link
Copy Markdown

@rgolangh: This pull request references OSAC-3830 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Extend the dorny/paths-filter exclusion list in all 6 workflows that use it (3 e2e, unit-tests, integration-tests, check-generated-code)
  • New exclusions: .claude/, .cursor/, .gemini/ (AI agent config), .design/ (design context), .skillsaw.yaml, .pre-commit-config.yaml
  • The existing exclusions (*.md, OWNERS, LICENSE, docs/) already cover documentation-only PRs — these additions cover AI agent configuration and development tooling that don't affect runtime behavior

Context

PR #213 (docs-only: adding AGENTS.md for osac-csi-driver) triggered all e2e workflow runs. The changes job correctly skipped the actual test jobs via the !**/*.md filter, but non-md files in .claude/ directories (settings.json, hooks) would not have been caught.

Test plan

  • Verify dorny/paths-filter syntax is correct (negation patterns follow .gitignore semantics)
  • Confirm existing code-change PRs still trigger tests (positive patterns unchanged)
  • This PR itself should demonstrate the skip behavior (workflow-only changes)

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@omer-vishlitzky

Copy link
Copy Markdown
Contributor

/retest

@github-actions

Copy link
Copy Markdown

Re-triggered failed runs:

  • label-gate (#31309088550)
  • label-gate (#31309076748)
  • E2E CaaS Full Install (#31309074307)
  • label-gate (#31309074098)

Extend the dorny/paths-filter exclusion list in all six workflows
(3 e2e, unit-tests, integration-tests, check-generated-code) to
skip test runs when PRs only touch non-code files: .claude/,
.cursor/, .gemini/ configs, .design/ context, .skillsaw.yaml,
and .pre-commit-config.yaml.

The existing exclusions (*.md, OWNERS, LICENSE, docs/) already
cover most documentation-only PRs. These additions cover AI agent
configuration and development tooling that don't affect runtime
behavior.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: Roy Golan <rgolan@redhat.com>
@omer-vishlitzky

Copy link
Copy Markdown
Contributor

/lgtm

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:32 PM UTC · Completed 2:45 PM UTC

Commit: 91327a8 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [protected-path] .github/workflows/* — All 6 changed files are under .github/, a protected path. Human approval is always required for changes to governance and infrastructure files, regardless of context. Affected files: check-generated-code.yaml, e2e-bmaas-full-install.yml, e2e-caas-full-install.yml, e2e-vmaas-full-install.yml, integration-tests.yml, unit-tests.yml.

Low

  • [consistency] .github/workflows/check-generated-code.yaml — This workflow adds .claude exclusions for its component-scoped paths (fulfillment-service/**, osac-operator/**) but does not add corresponding .cursor or .gemini exclusions, unlike the other 5 workflows which exclude all three AI agent config directories. If .cursor/ or .gemini/ directories are later added under these components, this workflow would trigger unnecessarily. Neither directory exists in these components today, so this is low-impact future-proofing. The root-level exclusions (.design/**, .skillsaw.yaml, .pre-commit-config.yaml) are correctly omitted since the component-scoped include patterns would never match root-level paths.

Labels: All 6 changed files are GitHub Actions workflow definitions under .github/workflows/

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

- '!fulfillment-service/LICENSE'
- '!fulfillment-service/**/*.md'
- '!fulfillment-service/docs/**'
- '!fulfillment-service/.claude/**'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[low] consistency

The check-generated-code workflow adds .claude exclusions for its component-scoped paths but does not add .cursor or .gemini exclusions, unlike the other 5 workflows which exclude all three AI agent config directories. If .cursor/ or .gemini/ directories are later added under fulfillment-service/ or osac-operator/, this workflow would trigger unnecessarily.

Suggested fix: Add !fulfillment-service/.cursor/, !fulfillment-service/.gemini/, !osac-operator/.cursor/, and !osac-operator/.gemini/ exclusions to both the on.pull_request.paths trigger and the dorny paths-filter block.

@fullsend-ai-review fullsend-ai-review Bot added requires-manual-review Review requires human judgment github_actions Pull requests that update GitHub Actions code labels Aug 11, 2026
@omer-vishlitzky
omer-vishlitzky added this pull request to the merge queue Aug 11, 2026
Merged via the queue into osac-project:main with commit 4594568 Aug 11, 2026
103 of 107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved github_actions Pull requests that update GitHub Actions code jira/valid-reference lgtm requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants