OSAC-3830: Skip CI for non-code changes: AI agent config, design, tooling - #214
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
WalkthroughThe pull-request filters for installation, integration-test, unit-test, and generated-code workflows now exclude assistant-related directories, design files, and selected configuration files. ChangesCI path filter exclusions
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@rgolangh: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eranco74, rgolangh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rgolangh: This pull request references OSAC-3830 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Re-triggered failed runs:
|
Extend the dorny/paths-filter exclusion list in all six workflows (3 e2e, unit-tests, integration-tests, check-generated-code) to skip test runs when PRs only touch non-code files: .claude/, .cursor/, .gemini/ configs, .design/ context, .skillsaw.yaml, and .pre-commit-config.yaml. The existing exclusions (*.md, OWNERS, LICENSE, docs/) already cover most documentation-only PRs. These additions cover AI agent configuration and development tooling that don't affect runtime behavior. Assisted-by: Claude Code <noreply@anthropic.com> Signed-off-by: Roy Golan <rgolan@redhat.com>
cb9d742 to
91327a8
Compare
|
/lgtm |
|
🤖 Finished Review · ✅ Success · Started 2:32 PM UTC · Completed 2:45 PM UTC Commit: |
ReviewFindingsMedium
Low
Labels: All 6 changed files are GitHub Actions workflow definitions under .github/workflows/ |
| - '!fulfillment-service/LICENSE' | ||
| - '!fulfillment-service/**/*.md' | ||
| - '!fulfillment-service/docs/**' | ||
| - '!fulfillment-service/.claude/**' |
There was a problem hiding this comment.
[low] consistency
The check-generated-code workflow adds .claude exclusions for its component-scoped paths but does not add .cursor or .gemini exclusions, unlike the other 5 workflows which exclude all three AI agent config directories. If .cursor/ or .gemini/ directories are later added under fulfillment-service/ or osac-operator/, this workflow would trigger unnecessarily.
Suggested fix: Add !fulfillment-service/.cursor/, !fulfillment-service/.gemini/, !osac-operator/.cursor/, and !osac-operator/.gemini/ exclusions to both the on.pull_request.paths trigger and the dorny paths-filter block.
4594568
Summary
dorny/paths-filterexclusion list in all 6 workflows that use it (3 e2e, unit-tests, integration-tests, check-generated-code).claude/,.cursor/,.gemini/(AI agent config),.design/(design context),.skillsaw.yaml,.pre-commit-config.yaml*.md,OWNERS,LICENSE,docs/) already cover documentation-only PRs — these additions cover AI agent configuration and development tooling that don't affect runtime behaviorContext
PR #213 (docs-only: adding AGENTS.md for osac-csi-driver) triggered all e2e workflow runs. The
changesjob correctly skipped the actual test jobs via the!**/*.mdfilter, but non-md files in.claude/directories (settings.json, hooks) would not have been caught.Test plan
dorny/paths-filtersyntax is correct (negation patterns follow.gitignoresemantics)🤖 Generated with Claude Code
Summary by CodeRabbit