Skip to content

A better approach for dark mode for some rendering in the editor. #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drgrice1 wants to merge 1 commit into
base: WeBWorK-2.21
Choose a base branch
from
+3 −6
Open

A better approach for dark mode for some rendering in the editor. #3029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions htdocs/js/PGProblemEditor/pgproblemeditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,6 @@
const iframe = document.createElement('iframe');
iframe.title = 'Rendered content';
iframe.id = 'pgedit-render-iframe';
iframe.style.colorScheme = 'light';

// Adjust editor dimensions when the window is resized and when the iframe loads.
const adjustIFrameHeight = () => {
Expand Down Expand Up @@ -667,8 +666,7 @@
if (fileType === 'hardcopy_theme') {
const contents = webworkConfig?.pgCodeMirror?.source;
if (contents) {
renderArea.innerHTML =
'<pre class="text-dark">' + contents.replace(/&/g, '&amp;').replace(/</g, '&lt;') + '</pre>';
renderArea.innerHTML = '<pre>' + contents.replace(/&/g, '&amp;').replace(/</g, '&lt;') + '</pre>';
} else
renderArea.innerHTML =
'<div class="alert alert-danger p-1 m-2 fw-bold">The file has no content.</div>';
Expand Down
1 change: 0 additions & 1 deletion htdocs/js/RenderProblem/renderproblem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@
iframe = document.createElement('iframe');
iframe.id = `${renderArea.id}_iframe`;
iframe.style.border = 'none';
iframe.style.colorScheme = 'light';
while (renderArea.firstChild) renderArea.firstChild.remove();
renderArea.append(iframe);

Expand Down
2 changes: 1 addition & 1 deletion templates/ContentGenerator/Instructor/PGProblemEditor.html.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
>
<i class="fa-solid fa-grip-lines-vertical fa-lg" aria-hidden="true"></i>
</div>
<div class="pgedit-panel render mb-lg-0 order-first order-lg-last bg-white">
<div class="pgedit-panel render mb-lg-0 order-first order-lg-last">
<div class="p-0" id="pgedit-render-area">
<div class="placeholder d-flex flex-column justify-content-center
align-items-center bg-secondary-subtle h-100">
Expand Down
2 changes: 1 addition & 1 deletion templates/ContentGenerator/Instructor/PGProblemEditor/pg_critic.html.ep
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
% Perl::Critic::Violation::set_format('%m at line %l, column %c.');
%
<div class="m-3 overflow-auto text-dark">
<div class="m-3 overflow-auto">
<h2><%= maketext('PG Critic Violations') %></h2>
% my @pgCriticViolations = grep { $_->policy =~ /^Perl::Critic::Policy::PG::/ } @$violations;
% my @perlCriticViolations = grep { $_->policy !~ /^Perl::Critic::Policy::PG::/ } @$violations;
Expand Down