A better approach for dark mode for some rendering in the editor.#3029
Open
drgrice1 wants to merge 1 commit into
Open
A better approach for dark mode for some rendering in the editor.#3029drgrice1 wants to merge 1 commit into
drgrice1 wants to merge 1 commit into
Conversation
This reworks what was done in openwebwork#3008 and openwebwork#3016. Rather than trying to force the PG critic and hardcopy xml into light mode, remove the `bg-white` class from the render panel and use the page colors. This means that these things are in a proper dark mode for those that use it. Problems do not need the white background since by default iframes are given a white background. Also the iframe elements do not need to have the `color-scheme` style set to `light`. That has no effect inside the iframe anyway.
drgrice1
force-pushed
the
better-pg-editor-dark-mode
branch
from
8171b45 to
a808818
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks what was done in #3008 and #3016. Rather than trying to force the PG critic and hardcopy xml into light mode, remove the
bg-whiteclass from the render panel and use the page colors. This means that these things are in a proper dark mode for those that use it.Problems do not need the white background since by default iframes are given a white background. Also the iframe elements do not need to have the
color-schemestyle set tolight. That has no effect inside the iframe anyway.