Fix merge conflict#2719
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: open-junius has repository write permission, a >2-year-old account, substantial contribution history, and prior merged subtensor PRs; branch fix-merge-conflict targets devnet-ready. Reviewed the full prefetched diff and contributor signals. The PR only adjusts FindingsNo findings. ConclusionNo malicious behavior or security vulnerability found in the static diff. The removed stake-operation-limit calls do not correspond to active helper definitions in the reviewed tree, while the remaining staking paths still enforce subnet existence, hotkey existence, balance/stake availability, lock availability, and safe arithmetic patterns relevant to this hunk. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Established contributor by history; no direct gittensor allowlist match found, but author has substantial recent subtensor activity (LIKELY). The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it. The PR is a small merge-conflict cleanup in The existing PR body is template-only, so I generated a proposed replacement body for the post-script to apply. No duplicate PR is a better candidate; the only complete overlap is the author's larger precompile/order work (#2685), while this PR is just the merge-conflict/runtime-version follow-up needed on the current target branch. No build/test run was needed: the diff is limited to resolving obsolete call sites and a version bump, and the surrounding call graph confirms FindingsNo findings. ConclusionApprove. The changes are narrowly scoped, consistent with the current staking API, and include the required runtime spec-version bump. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
|
duplicated with #2720 |
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.