feat: add support for custom ca - #51
Merged
Merged
Conversation
AndresNico
force-pushed
the
feat/add-private-ca-support
branch
2 times, most recently
from
May 28, 2026 12:36
e419ce1 to
754cd96
Compare
AndresNico
marked this pull request as ready for review
May 28, 2026 12:51
AndresNico
force-pushed
the
feat/add-private-ca-support
branch
from
June 8, 2026 17:00
3955e89 to
51c70a0
Compare
maximiliantech
requested changes
Jun 15, 2026
Member
There was a problem hiding this comment.
@AndresNico Thank you so much for this massive PR 🤝 Overall, this PR is very solid! 🚀 I have some comments that you can see below. Could you have a look please?
Member
|
@AndresNico And it seems that there are merge conflicts in the README. Could you have a look there as well please? 🙏 |
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
AndresNico
force-pushed
the
feat/add-private-ca-support
branch
from
June 16, 2026 10:25
0286aa9 to
00155df
Compare
maximiliantech
requested changes
Jun 17, 2026
maximiliantech
left a comment
maximiliantech
left a comment
Member
There was a problem hiding this comment.
Thanks for this PR 🫶 Could you please have a look at my comments below?
maximiliantech
approved these changes
Jun 18, 2026
maximiliantech
left a comment
maximiliantech
left a comment
Member
There was a problem hiding this comment.
LGTM 🚀 Thanks for this massive contribution @AndresNico ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: @SAP nico.andres@sap.com
What this PR does / why we need it:
Add support for custom ca
Which issue(s) this PR fixes:
Fixes #3
Special notes for your reviewer:
Release note: