feat: add support for custom ca - #281
Merged
Merged
Conversation
robertgraeff
previously approved these changes
Jun 16, 2026
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
AndresNico
force-pushed
the
feat/custom-ca-support
branch
from
June 16, 2026 11:41
d75417c to
537da2d
Compare
On-behalf-of: @SAP nico.andres@sap.com Signed-off-by: Nico Andres (SAP) <nico.andres@sap.com>
Contributor
Author
|
@robertgraeff resolved merge conflict, changed CaBundleRef to CABundleRef as mentioned here and update ca quality criterion. Would be great if I could get another review. |
robertgraeff
approved these changes
Jun 16, 2026
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On-behalf-of: @SAP nico.andres@sap.com
What this PR does / why we need it:
Adds support for custom CA certificates
Which issue(s) this PR fixes:
Fixes #245
Special notes for your reviewer:
Release note: