Skip to content

change re-encap weights #5457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dracazacula wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

change re-encap weights #5457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion feature/gribi/otg_tests/encap_frr_with_reencap_vrf_test/encap_frr_with_reencap_vrf_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ func configureGribiRoute(ctx context.Context, t *testing.T, dut *ondatra.DUTDevi
WithIPinIP(ipv4OuterSrc222Addr, gribiIPv4EntryVRF2225).
WithNextHopNetworkInstance(niTEVRF222),
fluent.NextHopGroupEntry().WithNetworkInstance(deviations.DefaultNetworkInstance(dut)).
WithID(1001).AddNextHop(1001, 1).AddNextHop(1003, 1).WithBackupNHG(2000),
WithID(1001).AddNextHop(1001, 1).AddNextHop(1003, 3).WithBackupNHG(2000),

fluent.NextHopEntry().WithNetworkInstance(deviations.DefaultNetworkInstance(dut)).
WithIndex(3000).WithNextHopNetworkInstance(niRepairVrf),
Expand Down Expand Up @@ -1026,6 +1026,12 @@ func TestEncapFrr(t *testing.T) {

configureDUT(t, dut, dutPorts)

if res, err := dut.RawAPIs().CLI(t).RunCommand(ctx, "show ver"); err == nil {
t.Logf("Output of 'show ver':\n%s", res.Output())
} else {
t.Logf("Failed to run 'show ver': %v", err)
}

Comment on lines +1029 to +1034
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The addition of the show ver CLI command is vendor-specific and unrelated to the stated purpose of this PR. While vendor-specific logic can be acceptable for non-OpenConfig paths when no cleaner validation method is available, feature profile tests should remain vendor-neutral by using OpenConfig paths (e.g., /system/state/software-version) whenever possible. Furthermore, Ondatra typically logs device information at the start of the test, making this manual check redundant. If you choose to replace this logic, ensure the new approach is verified across all supported vendors to maintain cross-platform compatibility.

References
  1. Use deviations to allow alternate OC paths or CLI commands to achieve the same operational intent. Do not use them to skip validation or change the intent of the test. (link)
  2. When dealing with non-OpenConfig paths, it may be acceptable to use brittle, vendor-specific logic if no cleaner validation method is available.
  3. When removing logic that handles vendor-specific naming conventions (such as stripping channelization from interface names), ensure the change is verified across all supported vendors to maintain cross-platform compatibility.

t.Log("Apply vrf selection policy to DUT port-1")
vrfpolicy.ConfigureVRFSelectionPolicy(t, dut, vrfpolicy.VRFPolicyC)

Expand Down
Loading