change re-encap weights#5457
Conversation
|
/fptest virtual |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration parameters for a specific GRIB-I test case to adjust traffic distribution weights and introduces diagnostic logging to capture device version information during test execution. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates a gRIBI next-hop weight and adds a manual CLI command to log the device version. Feedback was provided regarding the use of vendor-specific CLI commands; it is recommended to use OpenConfig paths for retrieving the software version to ensure the test remains vendor-neutral and adheres to the repository's style guidelines.
| if res, err := dut.RawAPIs().CLI(t).RunCommand(ctx, "show ver"); err == nil { | ||
| t.Logf("Output of 'show ver':\n%s", res.Output()) | ||
| } else { | ||
| t.Logf("Failed to run 'show ver': %v", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
The addition of the show ver CLI command is vendor-specific and unrelated to the stated purpose of this PR. While vendor-specific logic can be acceptable for non-OpenConfig paths when no cleaner validation method is available, feature profile tests should remain vendor-neutral by using OpenConfig paths (e.g., /system/state/software-version) whenever possible. Furthermore, Ondatra typically logs device information at the start of the test, making this manual check redundant. If you choose to replace this logic, ensure the new approach is verified across all supported vendors to maintain cross-platform compatibility.
References
- Use deviations to allow alternate OC paths or CLI commands to achieve the same operational intent. Do not use them to skip validation or change the intent of the test. (link)
- When dealing with non-OpenConfig paths, it may be acceptable to use brittle, vendor-specific logic if no cleaner validation method is available.
- When removing logic that handles vendor-specific naming conventions (such as stripping channelization from interface names), ensure the change is verified across all supported vendors to maintain cross-platform compatibility.
2 participants
No description provided.