Add 'show_changes' to "file.append" and "file.prepend" state functions#760
Open
meaksh wants to merge 4 commits into
Open
Add 'show_changes' to "file.append" and "file.prepend" state functions#760meaksh wants to merge 4 commits into
meaksh wants to merge 4 commits into
Conversation
Co-authored-by: Adam Bolte <adam.bolte@sitepoint.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the
show_changesargument tofile.appendandfile.prependstate functions in order to allow hiding the diff of the content as part of the output. Same behavior thatfile.managedstate and others.Upstream PR: saltstack/salt#69009
Previous Behavior
The output from
file.appendandfile.prependexecutions always contains a "diff" when files are text files.New Behavior
By default, the "diff" is included, but this can be skipped when
show_changesis set toFalse.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.