Skip to content

Do not expose GH credentials in the output from OpenTofu deployment#2137

Open
meaksh wants to merge 1 commit into
masterfrom
master-fix-output
Open

Do not expose GH credentials in the output from OpenTofu deployment#2137
meaksh wants to merge 1 commit into
masterfrom
master-fix-output

Conversation

@meaksh
Copy link
Copy Markdown
Member

@meaksh meaksh commented Apr 29, 2026

DO NOT MERGE THIS YET. IT REQUIRES openSUSE/salt#760 to be merged and released

What does this PR change?

This PR makes the salt state that configures the GH credentials in the controller node to not display the GH credentials as part of the state execution summary:

cucumber_testsuite.controller.provisioning[0] (remote-exec):----------
cucumber_testsuite.controller.provisioning[0] (remote-exec):       ID: git_config
cucumber_testsuite.controller.provisioning[0] (remote-exec): Function: file.append
cucumber_testsuite.controller.provisioning[0] (remote-exec):     Name: ~/.netrc
cucumber_testsuite.controller.provisioning[0] (remote-exec):   Result: True
cucumber_testsuite.controller.provisioning[0] (remote-exec):  Comment: Appended 4 lines
cucumber_testsuite.controller.provisioning[0] (remote-exec):  Started: 13:57:32.235144
cucumber_testsuite.controller.provisioning[0] (remote-exec): Duration: 3.858 ms
cucumber_testsuite.controller.provisioning[0] (remote-exec):      Changes:
cucumber_testsuite.controller.provisioning[0] (remote-exec):        ----------
cucumber_testsuite.controller.provisioning[0] (remote-exec):        diff:
cucumber_testsuite.controller.provisioning[0] (remote-exec):            --- 
cucumber_testsuite.controller.provisioning[0] (remote-exec):            +++ 
cucumber_testsuite.controller.provisioning[0] (remote-exec):            @@ -0,0 +1,4 @@
cucumber_testsuite.controller.provisioning[0] (remote-exec):            +machine github.com
cucumber_testsuite.controller.provisioning[0] (remote-exec):            +login XXXXXXXXXXX
cucumber_testsuite.controller.provisioning[0] (remote-exec):            +password XXXXXXXXXXXXXXXXXXX
cucumber_testsuite.controller.provisioning[0] (remote-exec):            +protocol https
cucumber_testsuite.controller.provisioning[0] (remote-exec):----------

@meaksh meaksh requested a review from a team as a code owner April 29, 2026 12:19
@meaksh meaksh force-pushed the master-fix-output branch from 176ce8a to f831c06 Compare April 29, 2026 15:06
Copy link
Copy Markdown
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants