fix(i18n): translate every connect account status in all locales - #1136
Open
raulriera wants to merge 1 commit into
Open
fix(i18n): translate every connect account status in all locales#1136raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
The status helper looked up pending, pending_review and unknown keys that no locale defined (locales only had an orphaned in_progress), so the missing-translation String hit [:title] in the settings and connect views and raised TypeError for practices mid-onboarding. Rename in_progress to pending (same copy) and add pending_review and unknown in en/es/pt, with a regression test covering every status in every locale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connect_account_status_i18ntranslatespending,pending_reviewandunknown, but no locale defined those keys (they defined an orphanedin_progressinstead), so the "translation missing" String hit[:title]inpractices/settingsandconnect_accounts/showand raised TypeError for any practice mid-onboardingin_progress→pending(the state it actually described, copy preserved) and addedpending_reviewandunknownsubtrees in en, es and ptTest plan