fix(api-service,worker): fail HTTP step on invalid Liquid template compilation

apps/api/src/app/workflows-v2/usecases/test-http-endpoint/test-http-endpoint.usecase.ts

@@ -1,4 +1,4 @@
-import { Injectable } from '@nestjs/common';
+import { BadRequestException, Injectable } from '@nestjs/common';
 import {
   buildNovuSignatureHeader,
   GetDecryptedSecretKey,
@@ -47,7 +47,14 @@ export class TestHttpEndpointUsecase {
 
     const compileContext = this.buildCompileContext(previewPayload);
 
-    const compiled = (await this.compileControlValues(controlValues, compileContext)) as typeof controlValues;
+    let compiled: typeof controlValues;
+    try {
+      compiled = (await this.compileControlValues(controlValues, compileContext)) as typeof controlValues;
+    } catch (cause) {
+      const message = cause instanceof Error ? cause.message : 'Unknown error';
+
+      throw new BadRequestException(`HTTP request step template compilation failed: ${message}`);
+    }
 
     const resolvedUrl = (compiled.url as string) ?? '';
     const method = (compiled.method as string) ?? 'GET';
@@ -145,7 +152,7 @@ export class TestHttpEndpointUsecase {
     try {
       return JSON.parse(compiled);
     } catch {
-      return values;
+      throw new Error('Rendered template output is not valid JSON');
     }
   }
 }

apps/worker/src/app/workflow/usecases/send-message/execute-http-request-step.usecase.ts

@@ -88,10 +88,35 @@ export class ExecuteHttpRequestStep extends SendMessageType {
       GetDecryptedSecretKeyCommand.create({ environmentId: command.environmentId })
     );
 
-    const compiled = (await this.compileControlValues(
-      controlValuesWithoutSkip,
-      compileContext
-    )) as typeof controlValuesWithoutSkip;
+    let compiled: typeof controlValuesWithoutSkip;
+    try {
+      compiled = (await this.compileControlValues(
+        controlValuesWithoutSkip,
+        compileContext
+      )) as typeof controlValuesWithoutSkip;
+    } catch (error) {
+      const errorMessage = error instanceof Error ? error.message : String(error);
+
+      await this.createExecutionDetails.execute(
+        CreateExecutionDetailsCommand.create({
+          ...CreateExecutionDetailsCommand.getDetailsFromJob(command.job),
+          detail: DetailEnum.ACTION_STEP_EXECUTION_FAILED,
+          source: ExecutionDetailsSourceEnum.INTERNAL,
+          status: ExecutionDetailsStatusEnum.FAILED,
+          isTest: false,
+          isRetry: false,
+          raw: JSON.stringify({
+            error: `HTTP request step template compilation failed: ${errorMessage}`,
+          }),
+        })
+      );
+
+      return {
+        status: SendMessageStatus.FAILED,
+        errorMessage: DetailEnum.ACTION_STEP_EXECUTION_FAILED,
+        shouldHalt: !controlValuesWithoutSkip.continueOnFailure,
+      };
+    }
 
     const url = compiled.url as string | undefined;
     const method = (compiled.method as string) ?? 'POST';
@@ -293,7 +318,7 @@ export class ExecuteHttpRequestStep extends SendMessageType {
     try {
       return JSON.parse(compiled);
     } catch {
-      return values;
+      throw new Error('Rendered template output is not valid JSON');
     }
   }