fix(api-service,worker): fail HTTP step on invalid Liquid template compilation

[cursor]

What changed

Wrapped liquidEngine.parseAndRender() in a try-catch inside compileControlValues() in both:

• API: TestHttpEndpointUsecase (apps/api/src/app/workflows-v2/usecases/test-http-endpoint/)
• Worker: ExecuteHttpRequestStep (apps/worker/src/app/workflow/usecases/send-message/)

Why

Sentry Error: API-R0 — TokenizationError: invalid value expression: "{subscriber.data.voice"

When users write HTTP request step templates with invalid Liquid syntax (e.g., unclosed braces like {subscriber.data.voice instead of {{subscriber.data.voice}}), LiquidJS throws a TokenizationError that was previously unhandled. This caused a 500 Internal Server Error to bubble up to Sentry.

The JSON.parse fallback was already wrapped in try-catch, but the parseAndRender call immediately above it was not — an oversight since both operations can fail on malformed user input.

Fix

On TokenizationError (or any Liquid parse/render failure), the method now returns the original uncompiled control values as a graceful fallback. This is consistent with the existing JSON.parse fallback pattern and matches how translate.usecase.ts handles the same error class.

Remaining risk

Low. The fallback returns raw template strings with unresolved variables, which is the same behavior as the existing JSON.parse catch path. Users will see their literal template text rather than a 500 error.

  

[netlify]

✅ Deploy Preview for dashboard-v2-novu-staging ready!

Name	Link
🔨 Latest commit	f5a59d0
🔍 Latest deploy log	https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69d75040da3bb00008ccaaa1
😎 Deploy Preview	https://deploy-preview-10623.dashboard-v2.novu-staging.co
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(api-service,worker): fail HTTP step on invalid Liquid template compilation

Requirements:

1. Follow the Conventional Commits specification
2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

[scopsy]

@cursoragent we should not fallback to the uncompiled version, if the compilation is broken we should throw an error

[cursor]

Here is what I implemented in response to @scopsy’s review (“do not fallback; throw on broken compilation”).

Changes

1. TestHttpEndpointUsecase (apps/api/src/app/workflows-v2/usecases/test-http-endpoint/test-http-endpoint.usecase.ts)

   • Wrapped compileControlValues in a try/catch that maps failures to BadRequestException with prefix HTTP request step template compilation failed: … so the dashboard test call gets 400, not 500.
   • compileControlValues now lets Liquid errors propagate and throws if JSON.parse fails on the rendered string (no more returning raw values).

2. ExecuteHttpRequestStep (apps/worker/src/app/workflow/usecases/send-message/execute-http-request-step.usecase.ts)

   • Same compileControlValues behavior (throw on Liquid failure or invalid JSON after render).
   • execute catches that, writes CreateExecutionDetails with the compilation error message, returns SendMessageStatus.FAILED and respects continueOnFailure—same pattern as missing URL / SSRF / HTTP errors.

Git

• Committed and pushed on cursor/sentry-error-investigation-05f2 (f5a59d0131).
• PR fix(api-service,worker): fail HTTP step on invalid Liquid template compilation #10623 title was updated to: fix(api-service,worker): fail HTTP step on invalid Liquid template compilation.
• The PR description could not be updated automatically (GitHub reports it is not agent-managed). You may want to edit the body manually to match the new behavior (fail fast, no silent fallback).

CI note

The bot still expects a Linear ticket in the title (fixes NOV-…) or in the branch name; add a ticket ID if you have one so pr-title-lint passes.